Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] graphs: add option to remove transitive dependencies in dependency graph
Date: Fri, 9 May 2014 12:20:29 +0200	[thread overview]
Message-ID: <20140509102029.GC3173@free.fr> (raw)
In-Reply-To: <877g5vb7bb.fsf@dell.be.48ers.dk>

Peter, All,

On 2014-05-09 12:00 +0200, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>  > On 2014-05-07 00:44 +0200, Yann E. MORIN spake thusly:
>  >> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  >> 
>  >> Currently, all the dependencies of a package are drawn on the dependency
>  >> graph, including transitive dependencies (e.g. A->B->C and A->C).
>  >> 
>  >> Very big graphs, with lots of packages with lots of dependencies, the
>  >> dependency graph can be very dense, and transitive dependencies are
>  >> cluttering the graph.
>  >> 
>  >> In some cases, only getting the "build-order" dependencies is enough (e.g.
>  >> to see what impact a package rebuild would have).
>  >> 
>  >> Add a new environment variable to disable drawing transitive dependencies.
> 
>  > I've marked it as Changes Requested in PAtchwork, since I have a cleaner
>  > patch to come soon, with other cleanups in the graph-depends script.
> 
> Thanks. Like I mentioned on IRC I do like the looks of the graphs, but
> I'm not really happy with the use of environment variables to control
> it, as it isn't intuitive.
> 
> Perhaps we should simply have kconfig options for these things?

As I said on IRC, I doubt this would be usefull, For example:

  - for depth: someone might want a 3-level deep graph for some package,
    and a 4-level deep graph for another,

  - for transitive deps: someone would like the complete dependencies
    graphed for some package, and only the 'build-order' deps for some
    another.

This means the user would have to go back to the menuconfig between each
graph, and this could not be made automatic (eg. called from within a
script that generates the graphs for the documentation of the project.)

What we could do, however, would be something like:

    make BR2_GRAPH_OPTS='--depth 4 --no-transitive' graph-depends

(the existing BR2_GRPAH_DEPS would disapear).

Thoughts?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-05-09 10:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 22:44 [Buildroot] [PATCH] graphs: add option to remove transitive dependencies in dependency graph Yann E. MORIN
2014-05-09  9:52 ` Yann E. MORIN
2014-05-09 10:00   ` Peter Korsgaard
2014-05-09 10:20     ` Yann E. MORIN [this message]
2014-05-09 11:16       ` Samuel Martin
2014-05-09 13:34         ` Yann E. MORIN
2014-05-09 14:09           ` Samuel Martin
2014-05-09 14:38             ` Yann E. MORIN
2014-05-09 15:07               ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509102029.GC3173@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox