[Buildroot] virtual-packages: the case for multiple providers selected

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Thomas De Schampheleire,

On Wed, 14 May 2014 09:21:33 +0200, Thomas De Schampheleire wrote:

> tdescham at argentina ~/repo/contrib/buildroot-bugs $ hg diff
> diff --git a/Config.in b/Config.in
> --- a/Config.in
> +++ b/Config.in
> @@ -369,6 +369,9 @@ config BR2_STRIP_none
>         help
>           Do not strip binaries and libraries in the target
>           filesystem.
> +
> +source "$BR2_EXTERNAL/test.in"
> +
>  endchoice
> 
>  config BR2_STRIP_EXCLUDE_FILES
> diff --git a/support/dummy-external/test.in b/support/dummy-external/test.in
> new file mode 100644
> --- /dev/null
> +++ b/support/dummy-external/test.in
> @@ -0,0 +1,2 @@
> +config BR2_STRIP_test
> +       bool "test"
> 
> 
> test.in would either exist in dummy-external, or in BR2_EXTERNAL, so
> there is no problem of missing files.
> It requires a separate file in BR2_EXTERNAL that has to be present if
> you choose to use BR2_EXTERNAL, but can be empty. Moreover, you need
> one such file for each choice you want to expand this way.
> I'm leaning more towards the preflight check, but I just want to
> highlight that expanding a choice from BR2_EXTERNAL is effectively
> possible.

Then it means that as soon as you define a BR2_EXTERNAL value, it
*must* point to a directory containing all the "<foo>.in" files for all
possible virtual packages that Buildroot has. This really doesn't seem
nice.

Remember, we're not talking about *one* choice option here, we're
talking about one *per* virtual package: one for EGL, one for OpenVG,
one for OpenGLES, one for OpenGL, one for ..., one for ...

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com