From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/8] graph-depends: document the max_depth variable
Date: Fri, 16 May 2014 23:33:14 +0200 [thread overview]
Message-ID: <20140516213314.GE3466@free.fr> (raw)
In-Reply-To: <20140516232641.201c1825@free-electrons.com>
Thomas, All,
On 2014-05-16 23:26 +0200, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
>
> On Fri, 16 May 2014 23:05:17 +0200, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Although unnecessary (we already have initialisation via the parser),
> > initialise the max_depth option, and document it at the same time.
>
> This description...
>
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> > Cc: Samuel Martin <s.martin49@gmail.com>
> > ---
> > support/scripts/graph-depends | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> > index c3dcbf1..dc6b98f 100755
> > --- a/support/scripts/graph-depends
> > +++ b/support/scripts/graph-depends
> > @@ -37,6 +37,9 @@ mode = 0
> > # Limit drawing the dependency graph to this depth. 0 means 'no limit'.
> > max_depth = 0
> >
> > +# Whether to draw the transitive dependencies
> > +transitive = True
> > +
>
> doesn't seem to match what the patch is doing. Am I missing something?
You are missing nothing. I am missing some sleep, a new pair of eyes,
and a brain. ;-)
The code is correct, and the commit log should be:
s/max_depth/transitive/
Thanks for spotting! :-)
I will respin after the dust has settled, to let other time to review.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-05-16 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 21:05 [Buildroot] [PATCH 0/8 v3] graph-depends improvements (branch yem/graphs) Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 1/8] graph-depends: rename the variable to pass the max depth Yann E. MORIN
2014-05-17 21:36 ` Peter Korsgaard
2014-05-16 21:05 ` [Buildroot] [PATCH 2/8] graphs: add option to remove transitive dependencies in dependency graph Yann E. MORIN
2014-05-30 21:00 ` Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 3/8] graphs-depends: merge redundant-dependencies elimination Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 4/8] graph-depends: handle the depth argument in a more pythonic way Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 5/8] graph-depends: document the max_depth variable Yann E. MORIN
2014-05-16 21:26 ` Thomas Petazzoni
2014-05-16 21:33 ` Yann E. MORIN [this message]
2014-05-16 21:05 ` [Buildroot] [PATCH 6/8] graph-depends: rename the mode constants Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 7/8] graph-depends: add option to pass arbitrary dot options Yann E. MORIN
2014-05-16 21:05 ` [Buildroot] [PATCH 8/8] manual: document the new graph-depends options Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516213314.GE3466@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox