From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nodejs: fix build when python3 is selected in Buildroot
Date: Wed, 21 May 2014 09:21:14 +0200 [thread overview]
Message-ID: <20140521092114.7f8caeb1@free-electrons.com> (raw)
In-Reply-To: <20140521025243.GI27238@tarshish>
Dear Baruch Siach,
On Wed, 21 May 2014 05:52:43 +0300, Baruch Siach wrote:
> > diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> > index b5973b5..7415bdf 100644
> > --- a/package/nodejs/nodejs.mk
> > +++ b/package/nodejs/nodejs.mk
> > @@ -35,8 +35,6 @@ define HOST_NODEJS_CONFIGURE_CMDS
> > --without-dtrace \
> > --without-etw \
> > )
> > - $(SED) "s@'python',@'$(HOST_DIR)/usr/bin/python2',@" \
> > - $(@D)/deps/v8/tools/gyp/v8.gyp
>
> The comment above 'define HOST_NODEJS_CONFIGURE_CMDS' should be updated to
> match.
Ah, right, indeed. Will send a v2.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-05-21 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 20:30 [Buildroot] [PATCH] nodejs: fix build when python3 is selected in Buildroot Thomas Petazzoni
2014-05-21 2:52 ` Baruch Siach
2014-05-21 7:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521092114.7f8caeb1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox