Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/11] toolchain-external: bump musl external toolchains to 1.1.1
Date: Sun, 1 Jun 2014 13:02:57 +0200	[thread overview]
Message-ID: <20140601130257.17e8b2b6@free-electrons.com> (raw)
In-Reply-To: <20140601105859.GD4280@tarshish>

Dear Baruch Siach,

On Sun, 1 Jun 2014 13:58:59 +0300, Baruch Siach wrote:

> > diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> > index a6c4061..47273d3 100644
> > --- a/toolchain/toolchain-external/toolchain-external.mk
> > +++ b/toolchain/toolchain-external/toolchain-external.mk
> > @@ -355,31 +355,32 @@ TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/14.05/components/toolchain/
> >  TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.9-2014.05_linux.tar.xz
> >  TOOLCHAIN_EXTERNAL_POST_INSTALL_STAGING_HOOKS += TOOLCHAIN_EXTERNAL_LINARO_AARCH64_SYMLINK
> >  else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_MUSL_CROSS),y)
> > -TOOLCHAIN_EXTERNAL_SITE = https://googledrive.com/host/0BwnS5DMB0YQ6bDhPZkpOYVFhbk0/musl-1.0.0/
> > +TOOLCHAIN_EXTERNAL_VERSION = 1.1.1
> 
> This name sounds too generic. Other external toolchains are unlikely to use 
> the same version string. Maybe MUSL_TOOLCHAIN_EXTERNAL_VERSION?

I believe it's OK: other toolchains could also define
TOOLCHAIN_EXTERNAL_VERSION (I'm actually thinking of sending patches to
do this). It's exactly like the choice between gcc versions in the gcc
package: we assign a different GCC_VERSION value in each case. That's
the same thing here: we have the choice between multiple toolchains and
toolchain versions, so it makes sense to have
TOOLCHAIN_EXTERNAL_VERSION defined to whatever the version of the
currently selected toolchain is.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-06-01 11:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01 10:47 [Buildroot] [PATCH 00/11] Round of external toolchain updates Thomas Petazzoni
2014-06-01 10:47 ` [Buildroot] [PATCH 01/11] toolchain-external: apply kernel headers check to non-custom toolchains Thomas Petazzoni
2014-06-08 16:10   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 02/11] toolchain-external: do not pass TOOLCHAIN_EXTERNAL_CFLAGS for kernel headers check Thomas Petazzoni
2014-06-08 16:17   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 03/11] toolchain-external: support only one Linaro ARM toolchain at a time Thomas Petazzoni
2014-06-08 16:18   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 04/11] toolchain-external: support only one Linaro AArch64 " Thomas Petazzoni
2014-06-08 16:19   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 05/11] toolchain-external: bump Linaro ARM to 2014.05 Thomas Petazzoni
2014-06-08 16:30   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 06/11] toolchain-external: bump Linaro ARMeb toolchain to 2014.04 Thomas Petazzoni
2014-06-08 16:37   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 07/11] toolchain-external: bump Linaro AArch64 toolchain to 2014.05 Thomas Petazzoni
2014-06-08 16:39   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 08/11] toolchain-external: bump musl external toolchains to 1.1.1 Thomas Petazzoni
2014-06-01 10:58   ` Baruch Siach
2014-06-01 11:02     ` Thomas Petazzoni [this message]
2014-06-13 12:49   ` Peter Korsgaard
2014-06-01 10:47 ` [Buildroot] [PATCH 09/11] toolchain-external: add CodeSourcery MIPS 2014.05, remove 2012.09 Thomas Petazzoni
2014-06-08 16:44   ` Yann E. MORIN
2014-06-01 10:47 ` [Buildroot] [PATCH 10/11] toolchain-external: add CodeSourcery PowerPC 2012.03 Thomas Petazzoni
2014-06-08 16:49   ` Yann E. MORIN
2014-06-08 16:54     ` Thomas Petazzoni
2014-06-13 13:00   ` Ryan Barnett
2014-06-01 10:47 ` [Buildroot] [PATCH 11/11] toolchain-external: add ADI Blackfin 2014R1 toolchain, remove 2012R1 Thomas Petazzoni
2014-06-08 17:16   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140601130257.17e8b2b6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox