From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package infra: remove duplicates in dependencies list
Date: Sun, 1 Jun 2014 15:15:43 +0200 [thread overview]
Message-ID: <20140601151543.0d804348@free-electrons.com> (raw)
In-Reply-To: <1401618534-16200-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 1 Jun 2014 12:28:54 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, we just use what a package declares as its dependencies.
>
> But some packages may declare the same depdency more than once. For
> example, php has two options to add SQL support: 'mysql' or 'mysqli',
> which are not exclusive. So, php.mk has mysql twice as a dependency.
>
> Although that does not cause any grievance for make, we end up generating
> dependency graphs where this duplicate dependency is visible.
>
> Add an intermediary variable which contains the $(sort)-ed list of the
> dependnecies, thus eliminating any duplicates.
Typo: dependencies
Also, I'm wondering: is it necessary to do this in the core package
infrastructure, or should we do it in the graph-depends tool, or even
do it only in the $(1)-show-depends target? I don't have a strong
disagreement with the patch, maybe after all it's cleaner to have the
dependencies sorted and with duplicates removed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-01 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 10:28 [Buildroot] [PATCH] package infra: remove duplicates in dependencies list Yann E. MORIN
2014-06-01 13:15 ` Thomas Petazzoni [this message]
2014-06-01 13:25 ` Yann E. MORIN
2014-06-08 16:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601151543.0d804348@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox