From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] packages: replace command install by $(INSTALL)
Date: Wed, 4 Jun 2014 19:37:31 +0200 [thread overview]
Message-ID: <20140604173731.GB3325@free.fr> (raw)
In-Reply-To: <9904698c937856394f641361bee0ffed.squirrel@sysmic.org>
J?r?me, All,
On 2014-06-04 16:00 +0200, "J?r?me Pouiller" spake thusly:
> On Sunday 01 June 2014 14:38:01 Maxime Hadjinlian wrote:
> > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> [...]
> > diff --git a/package/alsa-utils/alsa-utils.mk
> > b/package/alsa-utils/alsa-utils.mk index 48b4bfd..2083c97 100644
> > --- a/package/alsa-utils/alsa-utils.mk
> > +++ b/package/alsa-utils/alsa-utils.mk
> > @@ -41,7 +41,7 @@ LSA_UTILS_TARGETS_$(BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST)
> > += usr/bin/speaker-tes define ALSA_UTILS_INSTALL_TARGET_CMDS
> > mkdir -p $(TARGET_DIR)/var/lib/alsa
> > for i in $(ALSA_UTILS_TARGETS_y); do \
> > - install -D -m 755 $(STAGING_DIR)/$$i $(TARGET_DIR)/$$i; \
> > + $(INSTALL) -D -m 755 $(STAGING_DIR)/$$i $(TARGET_DIR)/$$i; \
> > done
> > if [ -x "$(TARGET_DIR)/usr/bin/speaker-test" ]; then \
> > mkdir -p $(TARGET_DIR)/usr/share/alsa/speaker-test; \
> [...]
>
> Just out of curiosity, why '$(INSTALL)' is preferred over 'install'?
Because it's been there for the past 9+ years? The commit #9cc9476c (more
dhcp updates) introduced this variable in 2005-02-16.
And because that's what we document in the manual? ;-)
More seriously, there's no much reason for now. But in the grand scheme
of the Universe, not all 'install' commands were made equal, so this
would allow us (in the case it is needed) to point $(INSTALL) to a
select 'install' command that we control.
Again, it's mostly historical bagage, but we want consistency acros
packages.
> And what about '$(RM)' versus 'rm'?
We do not have $(RM) currently, since all 'rm' commands are pretty much
on par with each others, so it is not really needed.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-04 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 12:38 [Buildroot] [PATCH] packages: replace command install by $(INSTALL) Maxime Hadjinlian
2014-06-01 13:10 ` Yann E. MORIN
2014-06-04 14:00 ` "Jérôme Pouiller"
2014-06-04 17:37 ` Yann E. MORIN [this message]
2014-06-08 15:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604173731.GB3325@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox