From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 07/11] support/scripts: do not display virtual packages in generated lists
Date: Wed, 4 Jun 2014 19:47:14 +0200 [thread overview]
Message-ID: <20140604174714.GC3325@free.fr> (raw)
In-Reply-To: <CAHXCMM+PxKqL0R==-d1SRJUcrAL_7V9Op=tyAeECvAjKZfcgmw@mail.gmail.com>
Samuel, All,
On 2014-06-03 00:53 +0200, Samuel Martin spake thusly:
> On Mon, Jun 2, 2014 at 11:06 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > If a package has both a 'real' and a 'virtual' definition, consider it
> > is a virtual package and do not display it in the generated package list.
> >
> > This is the case for jpeg and cryptodev, that are virtual packages, but
> > also real (but empty) packages used to provide a prompt to enable/disable
> > a choice to select an implementation. In this case, we do not want to
> > list the virtual packages, but only their implementations.
> >
> > So, consider packages that are both real and virtual as virtual packages.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Samuel Martin <s.martin49@gmail.com>
> > Acked-by: Samuel Martin <s.martin49@gmail.com>
> >
> > ---
> > Changes RFC -> v2:
> > - fix typoes (Samuel)
> > ---
> > support/scripts/gen-manual-lists.py | 21 +++++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/support/scripts/gen-manual-lists.py b/support/scripts/gen-manual-lists.py
> > index e234ef1..a3fb00c 100644
> > --- a/support/scripts/gen-manual-lists.py
> > +++ b/support/scripts/gen-manual-lists.py
> > @@ -279,13 +279,30 @@ class Buildroot:
> > pkg_list.append(re.sub(r"(.*?)\.mk", r"\1", file_))
> > setattr(self, "_package_list", pkg_list)
> > for pkg in getattr(self, "_package_list"):
> > - if pattern.match(pkg):
> > - return True
> > + if type == 'real' or type == 'both':
>
> Ooops! I forgot, since you removed the 'both' semantic in the previous
> patch, it should no longer appears here ;-)
Ah, right, I fixed it here. Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-04 17:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 21:06 [Buildroot] [PATCH 0/11 v2] Add list of virtual packages to manual (branch yem/manual) Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 01/11] package/cryptodev: make it behave more like other virtual packages Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 02/11] package/jpeg: " Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 03/11] package/mesa3d: rename the prompt Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 04/11] support/scripts: prepare expanding the packages lists Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 05/11] support/scripts: document args to _is_package() in gen-manual-lists Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 06/11] support/scripts: prepare handling virtual packages in generated lists Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 07/11] support/scripts: do not display " Yann E. MORIN
2014-06-02 22:53 ` Samuel Martin
2014-06-04 17:47 ` Yann E. MORIN [this message]
2014-06-02 21:06 ` [Buildroot] [PATCH 08/11] support/scripts: who's responsible to decide what is a package Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 09/11] support/scripts: introduce a symbol formatter to generate package lists Yann E. MORIN
2014-06-02 22:53 ` Samuel Martin
2014-06-03 6:10 ` Yann E. MORIN
2014-06-04 17:48 ` Yann E. MORIN
2014-06-02 21:06 ` [Buildroot] [PATCH 10/11] support/scripts: generate a list of virtual packages Yann E. MORIN
2014-06-02 22:57 ` Samuel Martin
2014-06-02 21:06 ` [Buildroot] [PATCH 11/11] docs/manual: add the virtual packages list Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2014-06-08 14:15 [Buildroot] [PATCH 0/11 v3] Add list of virtual packages to manual (branch yem/manual) Yann E. MORIN
2014-06-08 14:15 ` [Buildroot] [PATCH 07/11] support/scripts: do not display virtual packages in generated lists Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604174714.GC3325@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox