From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/2] xbmc: fix missing libraries from rpi-userland
Date: Thu, 5 Jun 2014 00:21:23 +0200 [thread overview]
Message-ID: <20140604222123.GH3325@free.fr> (raw)
In-Reply-To: <1401880448-2496-2-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2014-06-04 13:14 +0200, Samuel Martin spake thusly:
> When rpi-userland libraries are built as shared-objects, not all needed
> libraries are passed in the LD_FLAGS, leading to failure at linkage.
>
> To avoid this issue, set the LIBS variable content in accordance with the
> INCLUDES variable value.
>
> The commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf currently works
> around this issue by forcing rpi-userland to be statically linked,
> whereas it is actually a LIBS flags problem in xbmc package.
>
> A follow-up patch fixes rpi-userland package.
>
> Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> changes v4 -> v5:
> - rebase
> - extend commit message
>
> changes v3 -> v4:
> - rebase
>
> changes v2 -> v3:
> - new patch
> ---
> package/xbmc/xbmc.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/xbmc/xbmc.mk b/package/xbmc/xbmc.mk
> index c7a4607..8c0146e 100644
> --- a/package/xbmc/xbmc.mk
> +++ b/package/xbmc/xbmc.mk
> @@ -53,7 +53,8 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> XBMC_DEPENDENCIES += rpi-userland
> XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
> XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> - -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux"
> + -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
> + LIBS="-lvcos -lvchostif"
> endif
>
> ifeq ($(BR2_PACKAGE_DBUS),y)
> --
> 1.9.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-04 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:14 [Buildroot] [PATCH v5 0/2] rpi-userland/xbmc fix Samuel Martin
2014-06-04 11:14 ` [Buildroot] [PATCH v5 1/2] xbmc: fix missing libraries from rpi-userland Samuel Martin
2014-06-04 22:21 ` Yann E. MORIN [this message]
2014-06-04 11:14 ` [Buildroot] [PATCH v5 2/2] rpi-userland: cleanup *_CONF_OPT Samuel Martin
2014-06-04 22:24 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604222123.GH3325@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox