Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Patch to add Tilera tilegx platform support
Date: Sun, 8 Jun 2014 17:22:41 +0200	[thread overview]
Message-ID: <20140608172241.24672d2b@free-electrons.com> (raw)
In-Reply-To: <53906ED8.90500@arni.lv>

Dear Arni,

On Thu, 05 Jun 2014 14:21:28 +0100, Arni wrote:

> I'm working on porting Tilera tilegx platform to OpenWRT project, but
> I'm sure you are also interested in it.
> Patch is very simple, hope someone will find it usefull. Here is the patch :

Thanks for this patch!

However, adding an architecture to Buildroot is a bit more than just
adding those few definitions. I'm mainly thinking:

 * Toolchain: did you test the internal toolchain backend? Or are
   external toolchains available?

 * Packages: how much user-space packages that have
   architecture-specific code support the tilegx platform? For example,
   libffi, or strace are such packages.

 * Support: if we start supporting a new architecture in Buildroot, we
   try to do it well. One aspect of this is that we would add this
   architecture to our automated build infrastructure, which tests
   random combinations of packages. Would you be willing to help fixing
   the issues that arise through this testing effort? It would be a bit
   annoying for us to add the support for an architecture, and then
   have nobody actively interested in it and therefore nobody fixing
   the various issues.

On a more anecdotal note, your Git commit is improperly formatted,
because your commit log contains some contents not relevant for a
commit log. It should look like just:

"""
Add support for Tilera tilegx architecture

This commit adds support for the tilegx CPU architecture designed by
Tilera.

Signed-off-by: You <you@domain.com>
"""

See
http://buildroot.org/downloads/manual/manual.html#submitting-patches
for details.


Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-06-08 15:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 13:21 [Buildroot] Patch to add Tilera tilegx platform support Arni
2014-06-08 15:22 ` Thomas Petazzoni [this message]
2014-07-16 17:40   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140608172241.24672d2b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox