From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/6] minidlna: do not select BR2_PACKAGE_GETTEXT_TOOLS
Date: Sun, 8 Jun 2014 22:55:12 +0200 [thread overview]
Message-ID: <20140608205512.GR3266@free.fr> (raw)
In-Reply-To: <1401654214-19384-2-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2014-06-01 22:23 +0200, Thomas Petazzoni spake thusly:
> Commit 9ff640ae30ca588228030faf2c6fd13af292cb66 ("minidlna: needs
> gettext and host-gettext tools if locale is enabled") modified the
> minidlna package to fix gettext related issues. As part of this patch,
> a select of BR2_PACKAGE_GETTEXT_TOOLS was added, which according to
> the commit title is used to have host-gettext tools installed.
>
> However, this is not what this option is about: this option is about
> having gettext tools installed on the target.
>
> Since this is not what minidlna needs, and we anyway plan to remove
> this BR2_PACKAGE_GETTEXT_TOOLS option, this commit removes this
> incorrect select statement.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Tested-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
> Cc: Bernd Kuhls <berndkuhls@hotmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/minidlna/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/minidlna/Config.in b/package/minidlna/Config.in
> index 4a46b0c..5c5306d 100644
> --- a/package/minidlna/Config.in
> +++ b/package/minidlna/Config.in
> @@ -14,7 +14,6 @@ config BR2_PACKAGE_MINIDLNA
> select BR2_PACKAGE_LIBJPEG
> select BR2_PACKAGE_SQLITE
> select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> - select BR2_PACKAGE_GETTEXT_TOOLS if BR2_NEEDS_GETTEXT_IF_LOCALE
> help
> MiniDLNA (aka ReadyDLNA) is server software with the aim of being
> fully compliant with DLNA/UPnP-AV clients.
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-08 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 20:23 [Buildroot] [PATCHv2 0/6] gettext improvements Thomas Petazzoni
2014-06-01 20:23 ` [Buildroot] [PATCHv2 1/6] minidlna: do not select BR2_PACKAGE_GETTEXT_TOOLS Thomas Petazzoni
2014-06-02 20:29 ` Bernd Kuhls
2014-06-08 20:55 ` Yann E. MORIN [this message]
2014-06-01 20:23 ` [Buildroot] [PATCHv2 2/6] gettext: remove support for gettext-tools on target Thomas Petazzoni
2014-06-08 21:27 ` Yann E. MORIN
2014-06-01 20:23 ` [Buildroot] [PATCHv2 3/6] gettext: optimize build time Thomas Petazzoni
2014-06-08 22:26 ` Yann E. MORIN
2014-06-01 20:23 ` [Buildroot] [PATCHv2 4/6] gettext: allow building when BR2_NEEDS_GETTEXT is not selected Thomas Petazzoni
2014-06-01 20:23 ` [Buildroot] [PATCHv2 5/6] ecryptfs-utils: select gettext, needed for command line utilities Thomas Petazzoni
2014-06-01 20:23 ` [Buildroot] [PATCHv2 6/6] docs/manual: update documentation about gettext handling Thomas Petazzoni
2014-06-02 5:50 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140608205512.GR3266@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox