From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 3/3] Add an BR2_GCC_ENABLE_GRAPHITE flag for the buildroot toolchain
Date: Mon, 9 Jun 2014 11:58:40 +0200 [thread overview]
Message-ID: <20140609115840.745671e0@free-electrons.com> (raw)
In-Reply-To: <BLU436-SMTP1389119D64FEA33BF25D8E5A8320@phx.gbl>
Dear Steve Thomas,
On Mon, 19 May 2014 19:48:13 +0000, Steve Thomas wrote:
> The gcc graphite optimisations such as loop-interchange, blocking
> and loop-flattening, also known as graphite are an optional feature of
> gcc that is very well supported since about gcc version 4.5.
>
> This patch adds support for graphite for the toolchain as an optional
> flag for versions 4.8 onwards as an optional flag, that is disabled by
> default.
>
> Signed-off-by: Steve Thomas <scjthm@live.com>
Patch applied, with a few changes, see below.
> +config BR2_GCC_SUPPORTS_GRAPHITE
> + bool
Indentation should be one tab.
And of course I've added the BR2_GCC_ENABLE_GRAPHITE option, otherwise
your patch wouldn't work.
> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
> index 32219cc..8a35dbd 100644
> --- a/package/gcc/gcc.mk
> +++ b/package/gcc/gcc.mk
> @@ -156,6 +156,16 @@ HOST_GCC_COMMON_DEPENDENCIES += host-mpc
> HOST_GCC_COMMON_CONF_OPT += --with-mpc=$(HOST_DIR)/usr
> endif
>
> +ifeq ($(BR2_GCC_ENABLE_GRAPHITE),y)
> +HOST_GCC_COMMON_DEPENDENCIES += \
> + host-isl \
> + host-cloog
Used a single line.
> +
> +#This is needed as with-isl doesn't work
> +HOST_GCC_COMMON_CONF_OPT += \
> + --disable-isl-version-check
Here, --with-isl and --with-cloog are working perfectly fine, as well
as --without-isl and --without-cloog, so I've used them.
Can you test if the latest master works for you?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-06-09 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400528893-4483-1-git-send-email-scjthm@live.com>
2014-05-19 19:48 ` [Buildroot] [PATCH v6 1/3] isl: new package Steve Thomas
2014-06-09 9:53 ` Thomas Petazzoni
2014-05-19 19:48 ` [Buildroot] [PATCH v6 2/3] cloog: " Steve Thomas
2014-06-09 9:57 ` Thomas Petazzoni
2014-05-19 19:48 ` [Buildroot] [PATCH v6 3/3] Add an BR2_GCC_ENABLE_GRAPHITE flag for the buildroot toolchain Steve Thomas
2014-05-30 12:30 ` Gustavo Zacarias
2014-06-09 9:58 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609115840.745671e0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox