Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] sispmctl: new package
Date: Mon, 9 Jun 2014 14:42:05 +0200	[thread overview]
Message-ID: <20140609144205.3dd41ead@free-electrons.com> (raw)
In-Reply-To: <1401375933-23332-1-git-send-email-phil@zankapfel.net>

Dear Phil Eichinger,

On Thu, 29 May 2014 17:05:33 +0200, Phil Eichinger wrote:
> 
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---
>  package/Config.in            |    1 +
>  package/sispmctl/Config.in   |   11 +++++++++++
>  package/sispmctl/sispmctl.mk |   17 +++++++++++++++++
>  3 files changed, 29 insertions(+)
>  create mode 100644 package/sispmctl/Config.in
>  create mode 100644 package/sispmctl/sispmctl.mk

Thanks, I've applied your patch, after making a small number of
changes. Here is the list of changes I made:

    [Thomas:
     - Add missing select of BR2_PACKAGE_LIBUSB, since
       BR2_PACKAGE_LIBUSB_COMPAT depends on it
     - Add missing thread dependency, since libusb requires threads.
     - Add missing wide-char dependency. Without wide char support,
       sispmctl doesn't build.
     - Rewrap the Config.in help text, and remove trailing whitespaces.
     - License is GPLv2+, not GPLv2.
     - Remove --disable-dependency-tracking from <pkg>_CONF_OPT. That's a
       global, standard, autoconf option, and there's no reason to pass it
       at the per-package level.]

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-06-09 12:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 15:05 [Buildroot] [PATCH 1/1] sispmctl: new package Phil Eichinger
2014-06-09 12:42 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609144205.3dd41ead@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox