Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Makefile: test if "dot" exists in graph-build and <pkg>-graph-depends
Date: Fri, 13 Jun 2014 19:55:44 +0200	[thread overview]
Message-ID: <20140613195544.21c8a1c0@free-electrons.com> (raw)
In-Reply-To: <1402679208-8304-2-git-send-email-fabio.porcedda@gmail.com>

Dear Fabio Porcedda,

On Fri, 13 Jun 2014 19:06:48 +0200, Fabio Porcedda wrote:

> -graph-build: $(O)/build/build-time.log
> +graph-prerequisites:
> +	@dot -? >/dev/null 2>&1 || \
> +		(echo "ERROR: The 'dot' program from Graphviz is needed for graph-depends" >&2; exit 1)
> +
> +graph-build: $(O)/build/build-time.log graph-prerequisites

This is wrong: graph-build does not need the dot program, it's just a
Python script that uses matplotlib.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-06-13 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 17:06 [Buildroot] [PATCH 1/2] manual: add prerequisites for graph generation Fabio Porcedda
2014-06-13 17:06 ` [Buildroot] [PATCH 2/2] Makefile: test if "dot" exists in graph-build and <pkg>-graph-depends Fabio Porcedda
2014-06-13 17:16   ` Yann E. MORIN
2014-06-17  9:13     ` Fabio Porcedda
2014-06-13 17:55   ` Thomas Petazzoni [this message]
2014-06-17  9:14     ` Fabio Porcedda
2014-06-13 17:17 ` [Buildroot] [PATCH 1/2] manual: add prerequisites for graph generation Yann E. MORIN
2014-06-17  8:20   ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613195544.21c8a1c0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox