From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] rpcbind : add startup script
Date: Sun, 15 Jun 2014 14:43:08 +0200 [thread overview]
Message-ID: <20140615144308.6763b930@free-electrons.com> (raw)
In-Reply-To: <1402832300-17147-1-git-send-email-sagaert.johan@skynet.be>
Dear Sagaert Johan,
On Sun, 15 Jun 2014 13:38:20 +0200, Sagaert Johan wrote:
> rpcbind must be started at boot time.
> Without this any nfs mount will fail.
>
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
Thanks!
> diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
> index 19bdace..6a946f9 100644
> --- a/package/rpcbind/rpcbind.mk
> +++ b/package/rpcbind/rpcbind.mk
> @@ -15,4 +15,12 @@ RPCBIND_CONF_ENV += \
> CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/tirpc/"
> RPCBIND_DEPENDENCIES += libtirpc
>
> +define RPCBIND_INSTALL_STARTUP_SCRIPT
> + [ -f $(TARGET_DIR)/etc/init.d/S30rpcbind ] || \
> + $(INSTALL) -m 0755 -D package/rpcbind/S30rpcbind \
> + $(TARGET_DIR)/etc/init.d/S30rpcbind
> +endef
> +
> +RPCBIND_POST_INSTALL_TARGET_HOOKS += RPCBIND_INSTALL_STARTUP_SCRIPT
This should instead be using the <pkg>_INIT_SYSV mechanism, see the
Buildroot manual.
Also, since you said portmap and rpcbind cannot be used simultaneously,
I think it would be good to reflect this in the dependencies. So, in a
separate patch, adding a "depends on !BR2_PACKAGE_RPCBIND" in portmap
would probably be good to have.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-06-15 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 11:38 [Buildroot] [PATCH 1/1] rpcbind : add startup script Sagaert Johan
2014-06-15 12:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140615144308.6763b930@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox