From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5 of 7 v3] toolchain-external: change version from 'undefined' to 'virtual'
Date: Mon, 16 Jun 2014 09:18:18 +0200 [thread overview]
Message-ID: <20140616091818.034ba824@free-electrons.com> (raw)
In-Reply-To: <CAAXf6LX4zN1bYaxdskq9Evc5uT2Rw2ip-U7Dqf78bOOXiQgf4A@mail.gmail.com>
Dear Thomas De Schampheleire,
On Sun, 8 Jun 2014 19:23:09 +0200, Thomas De Schampheleire wrote:
> I also think the second approach of creating individual external
> toolchain packages is overkill.
I actually don't know. The current toolchain-external/Config.in and
toolchain-external/toolchain-external.mk are very long, splitting them
wouldn't be that bad. I'd like to think a bit more about this, and see
if a solution with individual packages wouldn't actually be better.
For example, one thing that the external toolchain stuff doesn't handle
today is fetching the source code for the toolchain.
> I don't think that the MESSAGE solution adds a lot of complexity: the
> current definition is:
> MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)
> $(1)$(TERM_RESET)"
> and this would become something like:
> MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME)
> $($(PKG)_EXTRA_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
>
> where FOO_EXTRA_NAME is a new variabel (name to be discussed) that can
> be set by any package (not only toolchain-external) if appropriate.
> This variable is default empty.
>
> This is not too complex, right?
It's not really whether it's complex or not: it's a feature that is
added to the core, common infrastructure, to solve the problem of just
one package. If we do this for each and every need of each single
package, the infrastructure is going to become an awful pile of crap,
and that's what I'd like to avoid.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-16 7:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 20:12 [Buildroot] [PATCH 0 of 7 v3] infra: fix dollar signs; remove some undefined versions Thomas De Schampheleire
2014-06-06 20:12 ` [Buildroot] [PATCH 1 of 7 v3] infra: consistently use double dollar signs inside inner-xxx-targets Thomas De Schampheleire
2014-06-06 21:21 ` Yann E. MORIN
2014-06-08 14:09 ` Thomas De Schampheleire
2014-06-07 8:49 ` Thomas Petazzoni
2014-06-08 14:29 ` Thomas De Schampheleire
2014-06-11 15:56 ` Thomas Petazzoni
2014-06-06 20:12 ` [Buildroot] [PATCH 2 of 7 v3] infra: add comment describing single/double dollar-sign rules Thomas De Schampheleire
2014-06-06 21:23 ` Yann E. MORIN
2014-06-07 8:52 ` Thomas Petazzoni
2014-06-06 20:12 ` [Buildroot] [PATCH 3 of 7 v3] pkg-virtual: simplify definition of FOO_VERSION to 'virtual' Thomas De Schampheleire
2014-06-06 20:13 ` [Buildroot] [PATCH 4 of 7 v3] toolchain/toolchain-buildroot: migrate to virtual package infrastructure Thomas De Schampheleire
2014-06-07 8:56 ` Thomas Petazzoni
2014-06-06 20:13 ` [Buildroot] [PATCH 5 of 7 v3] toolchain-external: change version from 'undefined' to 'virtual' Thomas De Schampheleire
2014-06-07 8:57 ` Thomas Petazzoni
2014-06-08 15:04 ` Thomas De Schampheleire
2014-06-08 16:10 ` Thomas Petazzoni
2014-06-08 17:23 ` Thomas De Schampheleire
2014-06-16 5:17 ` Arnout Vandecappelle
2014-06-16 6:54 ` Thomas De Schampheleire
2014-06-16 7:18 ` Thomas Petazzoni [this message]
2014-06-06 20:13 ` [Buildroot] [PATCH 6 of 7 v3] makedevs: change version from 'undefined' to 'buildroot-$(BR2_VERSION)' Thomas De Schampheleire
2014-06-06 20:13 ` [Buildroot] [PATCH 7 of 7 v3] mkpasswd: " Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616091818.034ba824@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox