From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [ANNOUNCE] Autobuilder script available, join the autobuilder effort!
Date: Wed, 18 Jun 2014 10:51:39 +0200 [thread overview]
Message-ID: <20140618105139.640b3a1f@free-electrons.com> (raw)
In-Reply-To: <CAAXf6LU6nesDDXVMDDyHeOHR4A-YB_=KCwfbCs50BTM2bNgE_w@mail.gmail.com>
Dear Thomas De Schampheleire,
On Wed, 18 Jun 2014 10:47:48 +0200, Thomas De Schampheleire wrote:
> > [environment-variables]
> > BR2_GIT = ...
> > BR2_FOO = ...
> >
> > and then the script makes sure to pass all these variables in the
> > environment when calling make on Buildroot.
>
> Ok, this is indeed better.
> It's probably easier (for parsing) to let the user specify one
> 'environment' string that contains
> "BR2_GIT=xxx BR2_FOO=yyy"
> than having separate config settings for possibly unknown options.
Right, even better.
> > Wouldn't it be simpler to simply kill the build process when the time
> > happens? So you have a cronjob that starts autobuild-run at 7 PM or 8
> > PM in the evening, and another one that kills autobuild-run at 7 AM or
> > 8 AM. I've tried to handle killing only the main autobuild-run script
> > and make sure it kills the building sub-processes, but it doesn't work
> > completely well so far. It needs to be investigated.
>
> It's easier, but it has the downside that the ongoing build at the
> time of the kill is always lost (no results available). In the case it
> happens to be a long build of two hours, it's a pity to lose these
> results if the 'stop-time' is not very strict.
That's true, but I find this thing really use-case specific. For
example, maybe on week-ends you will be able to let the builds run even
during day time? So we need to make the script more complex to handle
this possibility, while cron is the perfect tool to do this kind of
thing.
*However* we could add something like a signal sent to the script that
tells it to stop the builds when they are finished. Either a Unix
signal like SIGUSR1, or the creation of a specific file in a specific
location, or something like that. When the script receives this signal,
it knows it should stop itself at the end of the current build. But the
mechanism to generate this signal (cronjob or whatever) remains
external to the script.
What do you think?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-18 8:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 19:23 [Buildroot] [ANNOUNCE] Autobuilder script available, join the autobuilder effort! Thomas Petazzoni
2014-06-17 10:24 ` Thomas De Schampheleire
2014-06-17 11:00 ` Thomas Petazzoni
2014-06-18 7:31 ` Thomas De Schampheleire
2014-06-18 8:25 ` Thomas Petazzoni
2014-06-18 8:47 ` Thomas De Schampheleire
2014-06-18 8:51 ` Thomas Petazzoni [this message]
2014-06-18 9:23 ` Thomas De Schampheleire
2014-06-18 11:51 ` Thomas De Schampheleire
2014-06-19 12:40 ` Thomas Petazzoni
2014-06-20 21:03 ` Matthew Weber
2014-06-21 17:20 ` Thomas Petazzoni
2014-06-22 18:37 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618105139.640b3a1f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox