Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] freescale-imx: bump to version 3.10.17-1.0.0
Date: Fri, 20 Jun 2014 23:01:46 +0200	[thread overview]
Message-ID: <20140620210146.GB26745@free.fr> (raw)
In-Reply-To: <CADCpmyNGmM_FoGGoiDS640wjjrQfNkMBsdf+HBfpFgn9aAptKw@mail.gmail.com>

Gary, All,

On 2014-06-19 19:40 -0700, Gary Bisson spake thusly:
> > > diff --git
> > a/package/freescale-imx/imx-vpu/imx-vpu-0001-fix-IOSystemInit-failure.patch
> > b/package/freescale-imx/imx-vpu/imx-vpu-0001-fix-IOSystemInit-failure.patch
> > > new file mode 100644
> > > index 0000000..b73a959
> > > --- /dev/null
> > > +++
> > b/package/freescale-imx/imx-vpu/imx-vpu-0001-fix-IOSystemInit-failure.patch
> > > @@ -0,0 +1,21 @@
> > > +[PATCH] fix IOSystemInit failure
> >
> > Please provide a more detailed comit log. Why do we need this?
> >
> 
> As I said in the first patch I used the nitrogen6x to do my testing, there
> is one "big" difference between freescale and boundary kernel which is the
> memory split (2G/2G for FSL, 3G/1G for Boundary). Clearly the VPU code has
> only been tested on Freescale kernels because there is no way it works on
> kernel with the latter splitting. The VPU init function returns an error if
> the allocated buffer address is < 0 which does not make any sense. Instead
> the test should be against MAP_FAILED (-1). Only after that patch I've been
> able to get the VPU decoding working. I will change the -1 into MAP_FAILED
> for the next patch.

OK, I see. You should also repeat this in the patch description, like:

    vpu-io: fix IOSystemInit failure

    There is one "big" difference between freescale and boundary kernel
    which is the memory split (2G/2G for FSL, 3G/1G for Boundary).

    Clearly the VPU code has only been tested on Freescale kernels
    because there is no way it works on kernel with the latter
    splitting. The VPU init function returns an error if the allocated
    buffer address is < 0, which happens with the 3G/1G split.

    Fix the test by checking against MAP_FAILED instead.

    Signed-off-by: You <you@there>

Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-06-20 21:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  4:03 [Buildroot] [PATCH 0/5] freescale: update userspace packages Gary Bisson
2014-06-19  4:03 ` [Buildroot] [PATCH 1/5] freescale-imx: bump to version 3.10.17-1.0.0 Gary Bisson
2014-06-19 16:20   ` Yann E. MORIN
2014-06-20  2:40     ` Gary Bisson
2014-06-20 21:01       ` Yann E. MORIN [this message]
2014-06-21  3:44         ` Eric Nelson
2014-06-19  4:03 ` [Buildroot] [PATCH 2/5] libfslvpuwrap: bump to version 1.0.46 Gary Bisson
2014-06-19  4:03 ` [Buildroot] [PATCH 3/5] libfslcodec: bump to version 3.0.11 Gary Bisson
2014-06-19  4:03 ` [Buildroot] [PATCH 4/5] libfslparser: " Gary Bisson
2014-06-19  4:03 ` [Buildroot] [PATCH 5/5] gst-fsl-plugins: " Gary Bisson
2014-06-20 21:12   ` Yann E. MORIN
2014-06-27  5:24 ` [Buildroot] [PATCH v2 00/11] freescale: update userspace packages Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 01/11] libfslvpuwrap: change version to be independent Gary Bisson
2014-06-29 19:01     ` Yann E. MORIN
2014-06-27  5:24   ` [Buildroot] [PATCH v2 02/11] freescale-imx: bump to version 3.10.17-1.0.0 Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 03/11] freescale-imx: update imx-lib package Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 04/11] freescale-imx: change platform choice to be common Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 05/11] freescale-imx: add imx-vpu package Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 06/11] libfslvpuwrap: bump to version 1.0.46 Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 07/11] libfslcodec: bump to version 3.0.11 Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 08/11] libfslparser: " Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 09/11] gst-fsl-plugins: " Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 10/11] imx-vpu: fix IOSystemInit failure Gary Bisson
2014-06-27  5:24   ` [Buildroot] [PATCH v2 11/11] imx-vpu: fix IOGetVirtMem return value checks Gary Bisson
2014-06-29 19:04   ` [Buildroot] [PATCH v2 00/11] freescale: update userspace packages Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620210146.GB26745@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox