From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] legal-info: extract even no-redistribute packages
Date: Sun, 22 Jun 2014 22:02:35 +0200 [thread overview]
Message-ID: <20140622220235.2da1f822@free-electrons.com> (raw)
In-Reply-To: <a7e86f7ce80cc74bf84a77bcd1faee3acd2e04b6.1403439879.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 22 Jun 2014 14:41:12 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, if a package is marked _REDISTRIBUTE = NO, then legal-info
> will not try to extract it first.
>
> If that package also declares some _LICENSE_FILES, legal-info fails
> if it is the only action we're trying to run:
>
> $ cat defconfig
> BR2_arm=y
> BR2_TOOLCHAIN_BUILDROOT_EGLIBC=y
> BR2_PACKAGE_LIBFSLCODEC=y
> $ make BR2_DEFCONFIG=$(pwd)/defconfig defconfig
> $ make legal-info
> [--SNIP--]
> cat: /home/ymorin/dev/buildroot/O/build/libfslcodec-3.5.7-1.0.0/EULA: No such file or directory
>
> Fix this by always having legal-info extract the archives if one or
> more _LICENSE_FILES are specified.
>
> We do this for all types of packages: overridden, local or 'normal'
> remote packages. Even though we do not save the sources for the
> overridden or local packages, we need to save their licensing info,
> so we need to extract them.
>
> This implies that we now need only PKG-source, not PKG-extract anymore,
> as a dependency of legal-info for packages we want to save (ie.
> redistributable, non-local and non-overriden packages.)
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Fabio Porcedda <fabio.porcedda@gmail.com>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-22 20:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 12:41 [Buildroot] [PATCH 0/4 v6] legal-info: extract packages to get license files (branch yem/legal) Yann E. MORIN
2014-06-22 12:41 ` [Buildroot] [PATCH 1/4] legal-info: extract even no-redistribute packages Yann E. MORIN
2014-06-22 20:02 ` Thomas Petazzoni [this message]
2014-06-22 12:41 ` [Buildroot] [PATCH 2/4] legal-info: save license files even for local or overridden packages Yann E. MORIN
2014-06-22 20:03 ` Thomas Petazzoni
2014-06-22 12:41 ` [Buildroot] [PATCH 3/4] legal-info: add a comment about what packages we save the tarballs of Yann E. MORIN
2014-06-22 20:04 ` Thomas Petazzoni
2014-06-22 12:41 ` [Buildroot] [PATCH 4/4] legal-info: rename legal-warning-pkg-savednothing helper Yann E. MORIN
2014-06-22 20:05 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2014-03-17 23:04 [Buildroot] [PATCH 0/4 v4] legal-info: extract packages to get license files (branch yem/legal) Yann E. MORIN
2014-03-17 23:04 ` [Buildroot] [PATCH 1/4] legal-info: extract even no-redistribute packages Yann E. MORIN
2014-03-18 17:36 ` Luca Ceresoli
2014-03-18 17:47 ` Yann E. MORIN
2014-03-18 18:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140622220235.2da1f822@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox