From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] graph-depends: remove unnecessary redirect of stderr
Date: Mon, 23 Jun 2014 22:42:30 +0200 [thread overview]
Message-ID: <20140623204230.GA3572@free.fr> (raw)
In-Reply-To: <1403554284-4935-2-git-send-email-arnout@mind.be>
Arnout, All,
On 2014-06-23 22:11 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> It hides any error messages reported by make.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Not sure what the test-case for that one would be, but it looks sane.
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/scripts/graph-depends | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> index 52c16ce..1ecfeda 100755
> --- a/support/scripts/graph-depends
> +++ b/support/scripts/graph-depends
> @@ -82,7 +82,7 @@ allpkgs = []
> def get_targets():
> sys.stderr.write("Getting targets\n")
> cmd = ["make", "-s", "--no-print-directory", "show-targets"]
> - p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
> + p = subprocess.Popen(cmd, stdout=subprocess.PIPE, universal_newlines=True)
> output = p.communicate()[0].strip()
> if p.returncode != 0:
> return None
> @@ -98,7 +98,7 @@ def get_depends(pkgs):
> cmd = ["make", "-s", "--no-print-directory" ]
> for pkg in pkgs:
> cmd.append("%s-show-depends" % pkg)
> - p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
> + p = subprocess.Popen(cmd, stdout=subprocess.PIPE, universal_newlines=True)
> output = p.communicate()[0]
> if p.returncode != 0:
> sys.stderr.write("Error getting dependencies %s\n" % pkgs)
> --
> 2.0.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-23 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 20:11 [Buildroot] [PATCH 1/2] graph-depends: support calling from recursive make Arnout Vandecappelle
2014-06-23 20:11 ` [Buildroot] [PATCH 2/2] graph-depends: remove unnecessary redirect of stderr Arnout Vandecappelle
2014-06-23 20:42 ` Yann E. MORIN [this message]
2014-06-23 21:13 ` Samuel Martin
2014-06-23 20:29 ` [Buildroot] [PATCH 1/2] graph-depends: support calling from recursive make Yann E. MORIN
2014-06-29 8:44 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623204230.GA3572@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox