Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: disable parallel build for uClibc 0.9.31
Date: Mon, 30 Jun 2014 16:42:16 +0200	[thread overview]
Message-ID: <20140630164216.601d4429@free-electrons.com> (raw)
In-Reply-To: <1404138620-7929-1-git-send-email-abrodkin@synopsys.com>

Dear Alexey Brodkin,

On Mon, 30 Jun 2014 18:30:20 +0400, Alexey Brodkin wrote:

> +# In uClibc 0.9.31 parallel building is broken so we have to disable it
> +# Fortunately uClibc 0.9.31 is only used by AVR32 and in its turn AVR32 is
> +# about to be removed from buildroot.
> +#
> +# So as soon as AVR32 is removed please revert this patch so instead of
> +# MAKE_UCLIBC normal "MAKE" is used in UCLIBC_BUILD_CMDS
> +ifeq ($(BR2_UCLIBC_VERSION_0_9_31),y)
> +	MAKE_UCLIBC = $(MAKE1)
> +else
> +	MAKE_UCLIBC = $(MAKE)
> +endif

Sorry to nitpick, but I'd prefer to use UCLIBC_MAKE as the variable
name. We use <PKG>_<SOMETHING> for all variables, so it would make more
sense to do the same.

>  define UCLIBC_BUILD_CMDS
> -	$(MAKE) -C $(@D) \
> +	$(MAKE_UCLIBC) -C $(@D) \

Your original patch changing MAKE1 -> MAKE changed two places, and
you're changing only one place here. To be sure, we should probably
change back both places, no?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-06-30 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 14:30 [Buildroot] [PATCH] uclibc: disable parallel build for uClibc 0.9.31 Alexey Brodkin
2014-06-30 14:42 ` Thomas Petazzoni [this message]
2014-06-30 16:01   ` Alexey Brodkin
2014-06-30 16:10     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630164216.601d4429@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox