From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] grub2: Specify boot partition
Date: Tue, 1 Jul 2014 11:14:13 +0200 [thread overview]
Message-ID: <20140701111413.1d573f2d@free-electrons.com> (raw)
In-Reply-To: <1404204289-8303-1-git-send-email-jezz@sysmic.org>
Dear J?r?me Pouiller,
On Tue, 1 Jul 2014 10:44:49 +0200, J?r?me Pouiller wrote:
> Since boot partition was not specified, grub tools try to detect it
> automatically. This patch add an option to force it.
>
> Notice I am not sure -p option is usefull when -c option is used.
This should not be part of the commit log. If you want to express such
comments, they should go...
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
... here.
Indeed, when the configuration is built into the image, I don't think
the prefix is very useful. But I believe that's OK.
> +config BR2_TARGET_GRUB2_BOOT_PARTITION
> + string "boot partition"
> + default "(hd0,msdos1)"
depends on BR2_TARGET_GRUB2_I386_PC
since there is no need to specify a boot partition for the EFI boot
cases.
> + Specifiy partition where /boot/grub/grub.cfg will be located.
Fix that with:
Specify the partition where the /boot/grub/grub.cfg is located.
Use (hd0,msdos1) for the first partition of the first disk if
using a legacy partition table, or (hd0,gpt1) if using GPT
partition table.
Other than that, looks OK. Can you quickly resend a v2 ?
Thanks a lot for looking into this problem!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-01 9:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 10:32 [Buildroot] Is grub-bios-setup the way to go to make a bootable CF? Lennart Ramberg
2014-06-27 18:32 ` Thomas Petazzoni
2014-06-30 8:23 ` Lennart Ramberg
2014-06-30 9:49 ` Thomas Petazzoni
2014-06-30 19:53 ` Lennart Ramberg
2014-06-30 22:41 ` Thomas Petazzoni
2014-07-01 8:44 ` [Buildroot] [PATCH] grub2: Specify boot partition Jérôme Pouiller
2014-07-01 9:14 ` Thomas Petazzoni [this message]
2014-07-01 8:49 ` [Buildroot] Is grub-bios-setup the way to go to make a bootable CF? Jérôme Pouiller
2014-07-01 19:32 ` Lennart Ramberg
2014-07-01 19:56 ` Jérôme Pouiller
2014-07-01 20:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701111413.1d573f2d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox