From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libv4l: Bump version to 1.0.1
Date: Tue, 1 Jul 2014 23:26:48 +0200 [thread overview]
Message-ID: <20140701232648.33bc4483@free-electrons.com> (raw)
In-Reply-To: <1404076714-1174-1-git-send-email-ezequiel@vanguardiasur.com.ar>
Dear Ezequiel Garcia,
On Sun, 29 Jun 2014 18:18:34 -0300, Ezequiel Garcia wrote:
> -config BR2_PACKAGE_LIBV4L_V4L2_CTL
> - bool "v4l2-ctl"
> - depends on BR2_INSTALL_LIBSTDCPP
> +config BR2_PACKAGE_LIBV4L_JPEG
> + bool "JPEG support"
I think there needs to be a justification as to why we want a
sub-option to enable jpeg support, as opposed to have it directly
handled as an optional dependency in the .mk file by testing
BR2_PACKAGE_JPEG.
> -comment "libv4l needs a toolchain w/ largefile, threads"
> +comment "libv4l needs a toolchain w/ largefile, threads and C++"
> depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_INSTALL_LIBSTDCPP
The main problem is here, you should use:
depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
Otherwise, the comment will not get displayed in the proper situations.
Can you fix that up and resend?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-01 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 21:18 [Buildroot] [PATCH] libv4l: Bump version to 1.0.1 Ezequiel Garcia
2014-07-01 21:26 ` Thomas Petazzoni [this message]
2014-07-02 2:35 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701232648.33bc4483@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox