From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch v3 1/1] systemd: rework network/tty units installation
Date: Wed, 2 Jul 2014 22:15:17 +0200 [thread overview]
Message-ID: <20140702221517.0590f17c@free-electrons.com> (raw)
In-Reply-To: <20140702174859.GA755@rmm-p1267483>
Dear Eric Le Bihan,
On Wed, 2 Jul 2014 19:49:00 +0200, Eric Le Bihan wrote:
> Looking back, converting the fixup of getty service from an post installation
> hook to a service installation was not a good idea, after all.
>
> $(PKG)_INSTALL_INIT_SYSTEMD is performed before installing the package itself
> in the target directory via $(PKG)_INSTALL_TARGET_CMDS. So the fixup will fail
> trying to delete a file that has not been installed yet... (D'Oh! I should
> have cleaned my build directory...).
>
> I will send a patch reverting this part.
Hum, right, I don't know if a fixup of a file belongs to
<pkg>_INSTALL_INIT_SYSTEMD. But the fact that <pkg>_INSTALL_INIT_<foo>
gets executed *before* the package is installed to the target looks a
bit weird. Is there a reason for that?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-02 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 9:52 [Buildroot] [Patch v3 1/1] systemd: rework network/tty units installation Eric Le Bihan
2014-06-23 16:41 ` Arnout Vandecappelle
2014-06-29 8:55 ` Thomas Petazzoni
2014-07-02 17:49 ` Eric Le Bihan
2014-07-02 20:15 ` Thomas Petazzoni [this message]
2014-07-02 22:31 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702221517.0590f17c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox