From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 2 Jul 2014 22:31:22 +0200 Subject: [Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script In-Reply-To: References: <87fvijbx17.fsf@dell.be.48ers.dk> <20140702174430.3f1377ce@free-electrons.com> <20140702192243.20920b70@free-electrons.com> Message-ID: <20140702223122.72ccaf58@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Thomas De Schampheleire, On Wed, 2 Jul 2014 19:31:08 +0200, Thomas De Schampheleire wrote: > > Ah, ok, thanks for the clarification. However that doesn't explain why > > the temporary repo in $(DL_DIR) is not being removed. That's a > > regression compared to the original code in the .mk file, no? > > Patch 11 does: > > -rm -rf "${repodir}" > +rm -rf "${repodir}" "${tmp_tar}" "${tmp_output}" > +exit ${ret} > > and > > -repodir="${BR2_DL_DIR}/${basename}" > +repodir="${basename}.tmp-git-checkout" > +tmp_tar="$( mktemp "${BUILD_DIR}/.XXXXXX" )" > +tmp_output="$( mktemp "${output}.XXXXXX" )" > > So from the code (haven't verified this now) there is no repo at all > in DL_DIR, so that repo does not need to be removed. The repo $repodir > _is_ removed, including all of the other temporary stuff tmp_tar and > tmp_output. > > Peter, did you test this with all patches applied? I think what Peter complains about is that with just PATCH 03/14 applied, the Git download method no longer works properly as it leaves the repo in $(DL_DIR). The fact that this problem may or may not get solved by a later patch in the series is more-or-less irrelevant here: Peter is just saying that the series is not perfectly bisectable, and he stopped reviewing when he saw an issue in PATCH 03/14. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com