Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] wget: remove redundant gettextize run
Date: Sun, 13 Jul 2014 06:26:23 +0300	[thread overview]
Message-ID: <20140713032623.GA2138@tarshish> (raw)
In-Reply-To: <1405186024-8170-3-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

On Sat, Jul 12, 2014 at 02:27:04PM -0300, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Please explain in the commit log that gettextize now runs unconditionally when 
enabling AUTORECONF.

baruch

> ---
>  package/wget/wget.mk | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/package/wget/wget.mk b/package/wget/wget.mk
> index 56ccfb5..c546aba 100644
> --- a/package/wget/wget.mk
> +++ b/package/wget/wget.mk
> @@ -13,14 +13,6 @@ WGET_LICENSE_FILES = COPYING
>  # patching gnulib .m4 file
>  WGET_AUTORECONF = YES
>  
> -# Ugly kludge to fix autoreconf with old gettext infra
> -# We need to gettextize before autoreconf to upgrade
> -WGET_DEPENDENCIES += host-gettext
> -define WGET_GETTEXTIZE
> -	cd $(@D) ; $(HOST_DIR)/usr/bin/gettextize -f
> -endef
> -WGET_PRE_CONFIGURE_HOOKS += WGET_GETTEXTIZE
> -
>  # Prefer full-blown wget over busybox
>  ifeq ($(BR2_PACKAGE_BUSYBOX),y)
>  	WGET_DEPENDENCIES += busybox

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2014-07-13  3:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 17:27 [Buildroot] [PATCH 1/3] gettext: add gettextize definition Gustavo Zacarias
2014-07-12 17:27 ` [Buildroot] [PATCH 2/3] infra: add gettextize run in AUTORECONF Gustavo Zacarias
2014-07-14 11:01   ` Thomas Petazzoni
2014-07-14 11:04     ` Gustavo Zacarias
2014-07-14 11:07     ` Gustavo Zacarias
2014-07-14 12:30     ` Yann E. MORIN
2014-07-14 12:40       ` Gustavo Zacarias
2014-07-14 12:47         ` Yann E. MORIN
2014-07-14 12:51           ` Gustavo Zacarias
2014-07-14 16:30     ` Arnout Vandecappelle
2014-07-14 19:23       ` Thomas Petazzoni
2014-07-15 13:44         ` Gustavo Zacarias
     [not found]         ` <53C52F0D.70004@zacarias.com.ar>
     [not found]           ` <20140715191515.160512e4@free-electrons.com>
     [not found]             ` <53C562F6.8080705@zacarias.com.ar>
2014-07-15 17:25               ` Gustavo Zacarias
2014-07-12 17:27 ` [Buildroot] [PATCH 3/3] wget: remove redundant gettextize run Gustavo Zacarias
2014-07-13  3:26   ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140713032623.GA2138@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox