From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] perl-net-ssleay: fix configure
Date: Tue, 15 Jul 2014 19:13:15 +0200 [thread overview]
Message-ID: <20140715191315.374226d2@free-electrons.com> (raw)
In-Reply-To: <1405381684-3844-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Tue, 15 Jul 2014 01:48:04 +0200, Yann E. MORIN wrote:
> This is because perl-net-ssleay's buildsystem is really completely
> brain-damaged. Other perl extensions do not behave like that, and
> instead are doing the only same thing to do: not add single quotes
same -> sane
> around the definition, and just use what they were provided for
> lddlflags.
lddflags -> LDDLFLAGS.
> So, just do the same for perl-net-ssleay. Since tweaking (yet once
> more) their buildsystem is too complex, we just use a post-configure
> hook to fix up the mess, by removing single quotes around the definition
> of LDDLFLAGS.
>
> Note: if only one option is specified, no single quotes are added,
> but out hook is a no-op in this case.
out -> our.
> +define PERL_NET_SSLEAY_FIX_MAKEFILE
> + $(SED) "s/^LDDLFLAGS = '\(.*\)'/LDDLFLAGS = \1/" $(@D)/Makefile
> +endef
> +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE
I've fixed these and added a short comment above the hook definition to
explain what it is doing. Committed!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-15 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 23:48 [Buildroot] [PATCH] perl-net-ssleay: fix configure Yann E. MORIN
2014-07-15 17:13 ` Thomas Petazzoni [this message]
2014-07-15 17:19 ` Yann E. MORIN
2014-07-16 6:15 ` Arnout Vandecappelle
2014-07-16 17:42 ` François Perrad
2014-07-16 20:07 ` Yann E. MORIN
2014-07-16 20:05 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2014-07-24 18:15 Francois Perrad
2014-07-24 18:29 ` Yann E. MORIN
2014-07-24 20:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715191315.374226d2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox