From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] qt5: Add an option to select default platform
Date: Wed, 16 Jul 2014 19:05:52 +0200 [thread overview]
Message-ID: <20140716170552.GA9252@free.fr> (raw)
In-Reply-To: <1405526331-31440-1-git-send-email-jezz@sysmic.org>
J?r?me, All,
On 2014-07-16 17:58 +0200, J?r?me Pouiller spake thusly:
> Whithout this path, default platform is automaticaly set (generally
> set to "eglfs" as defined in
> qt5base/mkspecs/devices/common/linux_device_pre.conf:1). This choice
> is not always what the user would like. Thus, user have to manually
> appends "-platform <BACKEND>" to command line when running any qt5
> application.
>
> This patch allows user to choose default platform explicitly.
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
Two very small nit-picks, below. Otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> v2:
> * Use a string instead of a choice
> * Improve help message
>
>
> package/qt5/qt5base/Config.in | 11 +++++++++++
> package/qt5/qt5base/qt5base.mk | 3 +++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
> index 24e5902..632711c 100644
> --- a/package/qt5/qt5base/Config.in
> +++ b/package/qt5/qt5base/Config.in
> @@ -144,6 +144,17 @@ config BR2_PACKAGE_QT5BASE_EGLFS
> comment "eglfs backend available if OpenGLES and EGL are enabled"
> depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_HAS_LIBGLES
>
> +config BR2_PACKAGE_QT5BASE_DEFAULT_QPA
> + string "Default graphical platform"
> + help
> + Choose the default platform abstraction to use for graphical
> + application (e.g xcb, linuxfb, eglfs, ...). If this is empty, the
applications <- plural, no?
> + default for your architecture will be used (usually this is eglfs).
> +
> + You can get a list of supported platform by running a Qt application
platforms <- plural, too, no?
Regards,
Yann E. MORIN.
> + with the option "-platform help" on your target. You can choose a
> + different platform at runtime with the -platform option.
> +
> config BR2_PACKAGE_QT5BASE_PRINTSUPPORT
> bool "print support module"
> select BR2_PACKAGE_QT5BASE_WIDGETS
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 618251e..fecde13 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -96,6 +96,9 @@ else
> QT5BASE_CONFIGURE_OPTS += -no-xcb
> endif
>
> +QT5BASE_DEFAULT_QPA = $(call qstrip,$(BR2_PACKAGE_QT5BASE_DEFAULT_QPA))
> +QT5BASE_CONFIGURE_OPTS += $(if $(QT5BASE_DEFAULT_QPA),-qpa $(QT5BASE_DEFAULT_QPA))
> +
> ifeq ($(BR2_PACKAGE_QT5BASE_EGLFS),y)
> QT5BASE_CONFIGURE_OPTS += -opengl es2 -eglfs
> QT5BASE_DEPENDENCIES += libgles libegl
> --
> 2.0.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-07-16 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 15:58 [Buildroot] [PATCH v2] qt5: Add an option to select default platform Jérôme Pouiller
2014-07-16 17:05 ` Yann E. MORIN [this message]
2014-07-16 17:50 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2014-07-04 16:11 Jérôme Pouiller
2014-07-15 20:31 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716170552.GA9252@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox