Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opencv: fix dependencies for the Qt and GTK backends
Date: Sun, 20 Jul 2014 16:02:40 +0200	[thread overview]
Message-ID: <20140720140240.GA501@free.fr> (raw)
In-Reply-To: <20140720104809.09052567@free-electrons.com>

Thomas, All,

On 2014-07-20 10:48 +0200, Thomas Petazzoni spake thusly:
> On Sat, 19 Jul 2014 20:35:42 +0200, Yann E. MORIN wrote:
> > diff --git a/package/opencv/Config.in b/package/opencv/Config.in
> > index 6e938d2..1a026a9 100644
> > --- a/package/opencv/Config.in
> > +++ b/package/opencv/Config.in
> > @@ -159,6 +159,7 @@ config BR2_PACKAGE_OPENCV_WITH_GTK
> >  	depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
> >  	depends on BR2_INSTALL_LIBSTDCPP
> >  	depends on BR2_USE_MMU # libgtk2 -> glib2
> > +	depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
> >  	select BR2_PACKAGE_LIBGTK2
> >  
> >  config BR2_PACKAGE_OPENCV_WITH_JASPER
> > @@ -188,11 +189,11 @@ config BR2_PACKAGE_OPENCV_WITH_QT
> >  	depends on BR2_INSTALL_LIBSTDCPP
> >  	depends on !BR2_avr32 # qt
> >  	depends on BR2_USE_MMU # qt
> > +	depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
> >  	select BR2_PACKAGE_QT
> >  	select BR2_PACKAGE_QT_STL
> >  	select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_OPENCV_LIB_HIGHGUI
> >  	select BR2_PACKAGE_QT_TEST       if BR2_PACKAGE_OPENCV_LIB_HIGHGUI
> 
> Can I remove these "if" now that the Qt support anyway depends on
> highgui ?

Yes, of course! I was a bit too quick at sending this patch, sorry... :-/

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2014-07-20 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-19 18:35 [Buildroot] [PATCH] package/opencv: fix dependencies for the Qt and GTK backends Yann E. MORIN
2014-07-20  8:48 ` Thomas Petazzoni
2014-07-20 14:02   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720140240.GA501@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox