Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 1/3] Rename package mpc to libmpc
Date: Mon, 21 Jul 2014 16:25:58 +0200	[thread overview]
Message-ID: <20140721162558.749a1393@free-electrons.com> (raw)
In-Reply-To: <1405951937-21226-2-git-send-email-jkrause@posteo.de>

Dear J?rg Krause,

On Mon, 21 Jul 2014 16:12:15 +0200, J?rg Krause wrote:

> diff --git a/package/mpc/mpc.mk b/package/libmpc/libmpc.mk
> similarity index 53%
> rename from package/mpc/mpc.mk
> rename to package/libmpc/libmpc.mk
> index 81ee5f0..766e113 100644
> --- a/package/mpc/mpc.mk
> +++ b/package/libmpc/libmpc.mk
> @@ -1,15 +1,15 @@
>  ################################################################################
>  #
> -# mpc
> +# libmpc
>  #
>  ################################################################################
>  
> -MPC_VERSION = 1.0.2
> -MPC_SITE = $(BR2_GNU_MIRROR)/mpc
> -MPC_LICENSE = LGPLv3+
> -MPC_LICENSE_FILES = COPYING.LESSER
> -MPC_INSTALL_STAGING = YES
> -MPC_DEPENDENCIES = gmp mpfr
> +LIBMPC_VERSION = 1.0.2
> +LIBMPC_SITE = $(BR2_GNU_MIRROR)/mpc
> +LIBMPC_LICENSE = LGPLv3+
> +LIBMPC_LICENSE_FILES = COPYING.LESSER
> +LIBMPC_INSTALL_STAGING = YES
> +LIBMPC_DEPENDENCIES = libgmp libmpfr

Did you actually test this? With the package named "mpc", we didn't had
to define MPC_SOURCE, as it is inferred from the package name. If the
package is named "libmpc", then surely, there needs to be a
LIBMPC_SOURCE specification.

That being said, I would prefer to find a different name for the mpc
package (mpd client) rather than renaming existing packages.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-21 14:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 14:12 [Buildroot] [RFC 0/3] Rename of mpc, gmp, mpfr to libmpc, libgmp, libmpfr Jörg Krause
2014-07-21 14:12 ` [Buildroot] [RFC 1/3] Rename package mpc to libmpc Jörg Krause
2014-07-21 14:25   ` Thomas Petazzoni [this message]
2014-07-21 16:30     ` Gustavo Zacarias
2014-07-21 18:19       ` Thomas Petazzoni
2014-07-22  8:23         ` Jörg Krause
2014-07-22 10:20           ` Gustavo Zacarias
2014-07-22 17:02             ` Yann E. MORIN
2014-07-22 18:11               ` Jörg Krause
2014-07-21 14:12 ` [Buildroot] [RFC 2/3] Rename package gmp to libgmp Jörg Krause
2014-07-21 14:12 ` [Buildroot] [RFC 3/3] Rename package mpfr to libmpfr Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721162558.749a1393@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox