From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package: remove the trailing slash sign from $(PKG)_SITE variable
Date: Mon, 21 Jul 2014 22:58:22 +0200 [thread overview]
Message-ID: <20140721225822.34be99b8@free-electrons.com> (raw)
In-Reply-To: <1379658454-6906-1-git-send-email-jerzy.grzegorek@trzebnica.net>
Dear Jerzy Grzegorek,
On Fri, 20 Sep 2013 08:27:34 +0200, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>
> Since the trailing slash is stripped from $($(PKG)_SITE) by pkg-generic.mk:
>
> $(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE))
>
> so it is redundant.
> This patch removes it from $(PKG)_SITE variable for BR consistency.
Since this patch has been around for quite some time now, it no longer
applies properly, so I've marked it as "Changes Requested" in our patch
tracking system.
I don't know if it's worth respining the patch. What do we want to do
regarding this? Yann, Arnout, an opinion?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-21 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 6:27 [Buildroot] [PATCH v2 1/1] package: remove the trailing slash sign from $(PKG)_SITE variable Jerzy Grzegorek
2014-07-21 20:58 ` Thomas Petazzoni [this message]
2014-07-21 21:08 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721225822.34be99b8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox