Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libpcap: fix build for uclinux target
Date: Sat, 26 Jul 2014 09:27:52 +0200	[thread overview]
Message-ID: <20140726092752.150736ed@free-electrons.com> (raw)
In-Reply-To: <15676708c0726cb3fbed1dfaafae5e85c918ff3f.1406267235.git.baruch@tkos.co.il>

Dear Baruch Siach,

On Fri, 25 Jul 2014 08:47:15 +0300, Baruch Siach wrote:
> As usual, uclinux is also linux. Also, -lpthread is needed to link the canusb
> test.
> 
> Fixes:
> http://autobuild.buildroot.net/results/3af/3af796bc0eaa8563f0fd1dfce090083482fa57b9/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

I've applied your patch, after making one minor change:

> +Also we need -lpthread for the test to build for noMMU targets.
> +
> +Signend-off-by: Baruch Siach <baruch@tkos.co.il>

Typo: Signend -> Signed.

Also, do you think you could send your new patch, as well as the
existing 0001 patch on libpcap to the upstream project? It'd be great
to be able to drop them at some point, and remove LIBPCAP_AUTORECONF =
YES.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-26  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  5:47 [Buildroot] [PATCH] libpcap: fix build for uclinux target Baruch Siach
2014-07-26  7:27 ` Thomas Petazzoni [this message]
2014-07-29 10:26   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140726092752.150736ed@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox