Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst-fsl-plugins: fix build for kernel headers >= 3.10
Date: Sat, 26 Jul 2014 12:01:55 +0200	[thread overview]
Message-ID: <20140726100155.GB3939@free.fr> (raw)
In-Reply-To: <20140726090257.0feb0d7f@free-electrons.com>

Thomas, All,

On 2014-07-26 09:02 +0200, Thomas Petazzoni spake thusly:
> On Fri, 25 Jul 2014 22:34:30 -0700, Gary Bisson wrote:
> > This package couldn't build using a toolchain with kernel headers >=
> > 3.10 because of the use of VIDIOC_DBG_G_CHIP_IDENT. As stated in
> > videodev2.h, this ioctl should never be used.
> > 
> > Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
> > ---
> > Yann, Thomas, all,
> > After looking at the source code it appears that nothing justifies the use of
> > that obsolete ioctl. Its only purpose is to get the video device name so this
> > patch actually removes those unnecessary calls.
> > Thanks,
> > Gary
> 
> So, if I'm correct, this supersedes the patches from Yann
> (http://patchwork.ozlabs.org/patch/373813/ and
> http://patchwork.ozlabs.org/patch/373814/), right ?

Well, 373813 is still valid: it is a clarification in the manual that
_AT_LEAST_X_Y symbols can be used to require either lowest or highest
headers version.

So, even if we end up noy needing this for this issue, it is still
valid, no?

But indeed, 373814 is supersedded by this patch from Gary (and I'm happy
of the outcome!) I'll mark the affected patches supserdded in Patchwork.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-07-26 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-26  5:34 [Buildroot] [PATCH] gst-fsl-plugins: fix build for kernel headers >= 3.10 Gary Bisson
2014-07-26  7:02 ` Thomas Petazzoni
2014-07-26 10:01   ` Yann E. MORIN [this message]
2014-07-26 17:12     ` Gary Bisson
2014-07-26 17:15       ` Yann E. MORIN
2014-07-26  9:58 ` Yann E. MORIN
2014-07-27  8:31 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140726100155.GB3939@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox