From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] Rebuild packages when their external config is updated
Date: Tue, 29 Jul 2014 21:38:37 +0200 [thread overview]
Message-ID: <20140729213837.1b147511@free-electrons.com> (raw)
In-Reply-To: <1400253776-21759-2-git-send-email-sojka@merica.cz>
Dear Michal Sojka,
On Fri, 16 May 2014 17:22:56 +0200, Michal Sojka wrote:
> Packages like busybox, Linux kernel or uclibc can "import" their
> configuration files from external location specified either in
> buildroot's .config or in an environment variable. Currently, this
> import happens only when the package is built for the first time. When
> the external config changes later, the package is not rebuilt with the
> updated configuration until the corresponding .stamp_configured file
> is manually deleted. This patch changes this to automatically rebuild
> the package, when its external configuration files is newer than
> .stamp_configured.
>
> The change is implemented in pkg-generic.mk so it automatically
> applies to all packages that use external config.
>
> This patch also changes $(pkg)-update-config targets, which export the
> internally used config files to external locations, to not change the
> modification time of the external config. This ensures that the
> package is not rebuilt just because its config file was exported.
>
> Finally, linux.mk used variable KERNEL_SOURCE_CONFIG to hold the file
> name of the external config. This was renamed to LINUX_SOURCE_CONFIG,
> in order to be compatible with the change in pkg-generic.mk.
>
> Signed-off-by: Michal Sojka <sojka@merica.cz>
Thanks for your patch. But following Gustavo's and Yann's feedback, we
decided to reject this approach. The user should start the rebuild of
the package manually after changing the configuration.
Note that there is currently an on-going work by Thomas De
Schampheleire on creating a kconfig-package infrastructure. You're
welcome to raise your use cases and participate to the discussion.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-29 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:22 [Buildroot] [PATCH v2 0/1] Rebuild packages when their external config is updated Michal Sojka
2014-05-16 15:22 ` [Buildroot] [PATCH v2 1/1] " Michal Sojka
2014-05-16 16:26 ` Gustavo Zacarias
2014-05-16 21:18 ` Yann E. MORIN
2014-07-29 19:38 ` Thomas Petazzoni [this message]
2014-07-29 20:39 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729213837.1b147511@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox