Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Add option to copy config file to rootfs
Date: Thu, 31 Jul 2014 20:17:41 +0200	[thread overview]
Message-ID: <20140731201741.7873aee9@free-electrons.com> (raw)
In-Reply-To: <14321197-e8a0-43d3-9bcf-2f3d53e60753@email.android.com>

Dear Thomas De Schampheleire,

On Thu, 31 Jul 2014 19:55:21 +0200, Thomas De Schampheleire wrote:

> >I think the case where one would want this file in the generated
> >filesystem is a corner case, and that it would be better served with
> >a post-build script.
> 
> I think this is a feature that deserves to be in Buildroot 
> directly.  Just like rootfs-overlay used to be
>  something that people had to do manually from their
> post build script, but later became a supported
>  feature because many people found it useful, or the
>  feature to set the root password, this is something that is
> generally useful by many users, even those that don't fully know how
> to use the post build script to it's full ability, or did not yet
> realize the usefulness of the saving of the configuration.

I don't really have a strong opinion on whether we should have this
feature or not, but what bothers me is adding yet another global config
option just for a small thing like that.

If we were to include the .config file in the rootfs, could we do it
unconditionally? Or would the .config file size be problematic?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-31 18:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 15:26 [Buildroot] [PATCH v2] Add option to copy config file to rootfs Nathaniel Roach
2014-07-31 17:16 ` Yann E. MORIN
2014-07-31 17:55   ` Thomas De Schampheleire
2014-07-31 18:17     ` Thomas Petazzoni [this message]
2014-07-31 18:40       ` Thomas De Schampheleire
2014-07-31 21:37         ` Yann E. MORIN
2014-08-01  4:45           ` Thomas De Schampheleire
2014-07-31 17:19 ` Matthew Weber
2014-07-31 21:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731201741.7873aee9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox