From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 31 Jul 2014 23:13:38 +0200 Subject: [Buildroot] [PATCH 4 of 6 v2] uclibc: only add targets if uclibc is enabled In-Reply-To: <540167f28c2d41530ceb.1406750285@localhost> References: <540167f28c2d41530ceb.1406750285@localhost> Message-ID: <20140731231338.205114b3@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Thomas De Schampheleire, On Wed, 30 Jul 2014 21:58:05 +0200, Thomas De Schampheleire wrote: > In analogy of linux.mk, only enable its targets (in particular the kconfig > targets (menuconfig, update-config, ...) when the uclibc package is actually > enabled. > > Signed-off-by: Thomas De Schampheleire > > --- > v2: rebase after making kconfig-package a full infra > > Note: now that kconfig-package is a full package infra (inheriting from > generic-package) this may seem a bit odd, as other packages do not do this. > Nevertheless, it does not hurt and will slightly improve the parsing of the > Makefiles when the package is not selected. > > package/uclibc/uclibc.mk | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff -r 083076145a2b -r 540167f28c2d package/uclibc/uclibc.mk > --- a/package/uclibc/uclibc.mk Tue Jul 22 20:35:36 2014 +0200 > +++ b/package/uclibc/uclibc.mk Wed Jul 23 20:12:32 2014 +0200 > @@ -539,7 +539,9 @@ > $(UCLIBC_INSTALL_UTILS_STAGING) > endef > > +ifeq ($(BR2_TOOLCHAIN_BUILDROOT_UCLIBC),y) > $(eval $(kconfig-package)) > +endif I actually don't like this that much, because I like a lot the fact that I can do "make -source" "make -extract", "make -patch" or even "make " (though this last case, for the specific situation of uClibc doesn't seem really possible). Though it's true it can be considered a bit strange to allow "make -patch" but not "make -menuconfig". Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com