Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v9] google-breakpad: integration into Makefile and Config.in
Date: Thu, 31 Jul 2014 23:15:21 +0200	[thread overview]
Message-ID: <20140731231521.3242d944@free-electrons.com> (raw)
In-Reply-To: <1406837335-9696-1-git-send-email-yann.morin.1998@free.fr>

Yann, Pascal,

(Adding Pascal in Cc.)

On Thu, 31 Jul 2014 22:08:55 +0200, Yann E. MORIN wrote:

> +config BR2_GOOGLE_BREAKPAD_ENABLE
> +	bool "Enable google-breakpad support"
> +	select BR2_PACKAGE_GOOGLE_BREAKPAD

The propagation of the dependencies of the google-breakpad package were
missing, so I added them here.

> +	help
> +	  This option will enable the use of google breakpad, a library and tool
> +	  suite that allows you to distribute an application to users with
> +	  compiler-provided debugging information removed, record crashes in
> +	  compact "minidump" files, send them back to your server and produce
> +	  C and C++ stack traces from these minidumps.  Breakpad can also write
> +	  minidumps on request for programs that have not crashed.

This help text...

> +
> +if BR2_GOOGLE_BREAKPAD_ENABLE
> +
> +config BR2_GOOGLE_BREAKPAD_INCLUDE_FILES
> +	string "List of executables and libraries to extract symbols from"
> +	default ""
> +	help
> +	  You may specify a space-separated list of binaries and libraries
> +	  with full paths relative to $(TARGET_DIR) of which debug symbols 
> +	  will be dumped for further use with google breakpad.
> +
> +	  A directory structure that can be used by minidump-stackwalk will
> +	  be created at:

... and this one were slightly too long, so I rewrapped them.


> +config BR2_PACKAGE_HOST_GOOGLE_BREAKPAD
> +	bool

I've removed this debugging leftover.

And then I've applied the patch. Thanks a lot Pascal and Yann for
having worked on this. A special thanks to Pascal for his persistence
to get this feature merged, despite our numerous requests to adjust the
implementation.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-31 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 20:08 [Buildroot] [PATCH v9] google-breakpad: integration into Makefile and Config.in Yann E. MORIN
2014-07-31 21:15 ` Thomas Petazzoni [this message]
2014-07-31 21:41   ` Yann E. MORIN
2014-08-01  9:19     ` Pascal Huerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731231521.3242d944@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox