Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 5 v3] uclibc: fixup config before calling menuconfig
Date: Sun, 3 Aug 2014 09:50:59 +0200	[thread overview]
Message-ID: <20140803075058.GC4052@free.fr> (raw)
In-Reply-To: <8fc7b26a491414b96420.1406922823@localhost>

Thomas, All,

On 2014-08-01 21:53 +0200, Thomas De Schampheleire spake thusly:
> The uclibc-menuconfig command is currently run based on the user-specified
> config file, while the fixup of the config file is done afterwards.
> However, it makes more sense to do an initial fixup _before_ running
> menuconfig, so that the options presented to the user are consistent with
> the final configuration.
> 
> This patch changes the dependency of the menuconfig target from .config to
> .stamp_config_fixup_done to achieve this.
> 
> Suggested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

I tested that the menuconfig does indeed display our specific options,
and that the intermediate stamp file is indeed removed after exiting the
menuconfig. Further calls also properly restore our options.

Regards,
Yann E. MORIN.

> 
> ---
> v3: new patch
> 
>  package/uclibc/uclibc.mk |  2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff -r 892938e37055 -r 8fc7b26a4914 package/uclibc/uclibc.mk
> --- a/package/uclibc/uclibc.mk	Mon Apr 28 06:58:48 2014 +0200
> +++ b/package/uclibc/uclibc.mk	Fri Aug 01 21:22:29 2014 +0200
> @@ -542,7 +542,7 @@
>  
>  $(UCLIBC_TARGET_CONFIGURE): $(UCLIBC_DIR)/.stamp_config_fixup_done
>  
> -uclibc-menuconfig: $(UCLIBC_DIR)/.config
> +uclibc-menuconfig: $(UCLIBC_DIR)/.stamp_config_fixup_done
>  	$(MAKE) -C $(UCLIBC_DIR) \
>  		$(UCLIBC_MAKE_FLAGS) \
>  		PREFIX=$(STAGING_DIR) \

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-08-03  7:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 19:53 [Buildroot] [PATCH 0 of 5 v3] Introduction of kconfig-package Thomas De Schampheleire
2014-08-01 19:53 ` [Buildroot] [PATCH 1 of 5 v3] uclibc: fixup config before calling menuconfig Thomas De Schampheleire
2014-08-03  7:50   ` Yann E. MORIN [this message]
2014-08-01 19:53 ` [Buildroot] [PATCH 2 of 5 v3] infra: introduce a kconfig-package infrastructure Thomas De Schampheleire
2014-08-03  8:14   ` Yann E. MORIN
2014-08-01 19:53 ` [Buildroot] [PATCH 3 of 5 v3] manual: add documentation for kconfig-package Thomas De Schampheleire
2014-08-01 20:50   ` Yann E. MORIN
2014-08-01 19:53 ` [Buildroot] [PATCH 4 of 5 v3] uclibc: convert to kconfig-package infrastructure Thomas De Schampheleire
2014-08-03  8:22   ` Yann E. MORIN
2014-08-01 19:53 ` [Buildroot] [PATCH 5 of 5 v3] busybox: " Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140803075058.GC4052@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox