Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/9 v3] support/download: convert localfiles to use the wrapper
Date: Sun, 3 Aug 2014 19:06:16 +0200	[thread overview]
Message-ID: <20140803170616.GH4052@free.fr> (raw)
In-Reply-To: <CAAXf6LXCOahmhBuYk7O=AMzDD_+JkmFVv73V1SaeGw6ESOPu4w@mail.gmail.com>

Thomas, All,

On 2014-08-03 09:56 +0200, Thomas De Schampheleire spake thusly:
> On Mon, Jul 21, 2014 at 12:42 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > This drastically simplifies the localfiles helper, as it no longer has
> > to deal with atomically saving the downloaded archive.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  package/pkg-download.mk |  4 ++--
> >  support/download/cp     | 20 +++++---------------
> >  2 files changed, 7 insertions(+), 17 deletions(-)
> >
> > diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> > index 6320338..94febab 100644
> > --- a/package/pkg-download.mk
> > +++ b/package/pkg-download.mk
> > @@ -205,8 +205,8 @@ endef
> >
> >  define DOWNLOAD_LOCALFILES
> >         test -e $(DL_DIR)/$(2) || \
> > -       $(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
> > -                                        $(DL_DIR)/$(2) && \
> > +       $(EXTRA_ENV) support/download/wrapper cp $(DL_DIR)/$(2) \
> > +                                                $(call stripurischeme,$(call qstrip,$(1))) && \
> >         $(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
> >  endef
> >
> > diff --git a/support/download/cp b/support/download/cp
> > index 8f6bc06..4945c56 100755
> > --- a/support/download/cp
> > +++ b/support/download/cp
> > @@ -5,22 +5,12 @@ set -e
> 
> Here you didn't make the comment change command->unexpected before set -e.

Yep, will do.

Regards,
Yann E. MORIN.


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-08-03 17:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20 22:42 [Buildroot] [PATCH 0/9 v3] Cleanups in download helpers (branch yem/check-downloads) Yann E. MORIN
2014-07-20 22:42 ` [Buildroot] [PATCH 1/9 v3] support/download: add download wrapper Yann E. MORIN
2014-08-03  7:18   ` Thomas De Schampheleire
2014-08-03  7:27     ` Yann E. MORIN
2014-07-20 22:42 ` [Buildroot] [PATCH 2/9 v3] support/download: convert bzr to use the wrapper Yann E. MORIN
2014-08-03  7:52   ` Thomas De Schampheleire
2014-08-03 17:05     ` Yann E. MORIN
2014-07-20 22:42 ` [Buildroot] [PATCH 3/9 v3] support/download: convert localfiles " Yann E. MORIN
2014-08-03  7:56   ` Thomas De Schampheleire
2014-08-03 17:06     ` Yann E. MORIN [this message]
2014-08-03 17:39   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 4/9 v3] support/download: convert cvs " Yann E. MORIN
2014-08-03 17:40   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 5/9 v3] support/download: convert git " Yann E. MORIN
2014-08-03 17:41   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 6/9 v3] support/download: convert Hg " Yann E. MORIN
2014-08-03 17:41   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 7/9 v3] support/download: convert scp " Yann E. MORIN
2014-08-03 17:42   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 8/9 v3] support/download: convert svn " Yann E. MORIN
2014-08-03 17:42   ` Thomas De Schampheleire
2014-07-20 22:42 ` [Buildroot] [PATCH 9/9 v3] support/download: convert wget " Yann E. MORIN
2014-08-03 17:43   ` Thomas De Schampheleire
2014-07-27 14:13 ` [Buildroot] [PATCH 0/9 v3] Cleanups in download helpers (branch yem/check-downloads) Thomas Petazzoni
2014-07-27 19:58   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140803170616.GH4052@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox