From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nodejs: Add dependency on zlib
Date: Wed, 6 Aug 2014 20:15:38 +0200 [thread overview]
Message-ID: <20140806201538.3843a111@free-electrons.com> (raw)
In-Reply-To: <1407279442-15084-1-git-send-email-paul@crapouillou.net>
Dear Paul Cercueil,
On Wed, 6 Aug 2014 00:57:22 +0200, Paul Cercueil wrote:
> index a85384e..ff44e01 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -7,9 +7,9 @@
> NODEJS_VERSION = 0.10.12
> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
> NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
> -NODEJS_DEPENDENCIES = host-python host-nodejs \
> +NODEJS_DEPENDENCIES = host-python host-nodejs zlib \
Ok.
> $(call qstrip,$(BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS))
> -HOST_NODEJS_DEPENDENCIES = host-python
> +HOST_NODEJS_DEPENDENCIES = host-python host-zlib
So here you're adding host-zlib as a dependency of host-nodejs.
> NODEJS_LICENSE = MIT (core code); MIT, Apache and BSD family licenses (Bundled components)
> NODEJS_LICENSE_FILES = LICENSE
>
> @@ -69,6 +69,7 @@ define NODEJS_CONFIGURE_CMDS
> $(HOST_DIR)/usr/bin/python2 ./configure \
> --prefix=/usr \
> --without-snapshot \
> + --shared-zlib \
However here you're only adding --shared-zlib to the target nodejs
configure options. Shouldn't --shared-zlib also be passed in
HOST_NODEJS_CONFIGURE_CMDS ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-08-06 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 22:57 [Buildroot] [PATCH] nodejs: Add dependency on zlib Paul Cercueil
2014-08-06 18:15 ` Thomas Petazzoni [this message]
2014-08-09 13:38 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806201538.3843a111@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox