From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] bcache-tools: Adding package.
Date: Thu, 7 Aug 2014 09:06:14 +0200 [thread overview]
Message-ID: <20140807090614.574ba202@free-electrons.com> (raw)
In-Reply-To: <20140806214852.GG1587@free.fr>
Dear Yann E. MORIN,
On Wed, 6 Aug 2014 23:48:52 +0200, Yann E. MORIN wrote:
> > +# The bcache-tools Makefile expects the man8 directory to exist.
> > +define BCACHE_TOOLS_INSTALL_MAN8
> > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/share/man/man8
> > +endef
>
> In Buildroot, the man pages are simply removed from the target/ dir jsut
> prior to generatign the filesystem images.
>
> Then, why not simply patch the Makefile to not install them in the first
> place? Like, in a post-extract hook.
I disagree. I would prefer to make a patch that actually fixes the
installation of the man pages and submit this patch upstream. This way,
when upstream releases a new version, we can get rid of the patch, and
simply do "make install" without any other thing to do. Buildroot will
take care of removing the man pages.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-08-07 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 17:29 [Buildroot] [PATCH v5] bcache-tools: Adding package Jean-Christophe DUBOIS
2014-08-06 21:48 ` Yann E. MORIN
2014-08-07 7:06 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807090614.574ba202@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox