From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] postgresql: remove devfiles from target
Date: Tue, 12 Aug 2014 18:50:19 +0200 [thread overview]
Message-ID: <20140812185019.57322578@free-electrons.com> (raw)
In-Reply-To: <CAAXf6LW2KLKO3836TUw+7BqFTcYBu=AjSvCHw9ff=jwx=sOCww@mail.gmail.com>
Dear Thomas De Schampheleire,
On Sun, 10 Aug 2014 14:54:51 +0200, Thomas De Schampheleire wrote:
> >> Not entirely sure here, but isn't the better approach for pg_config to add
> >> it to POSTGRESQL_CONFIG_SCRIPTS? This will ensure the file is fixed up for
> >> staging usr, and removed from target automatically.
> >>
> >
> > Note that pg_config is an ELF executable compiled for the target
> > architecture, and not a text script that can be easily fixed up.
>
> Ok, in this case adding it to POSTGRESQL_CONFIG_SCRIPTS may not be the
> best idea.
More precisely: it will simply not work. The <pkg>_CONFIG_SCRIPTS
mechanism assumes that the <pkg>-config files are shell scripts, in a
certain format. With an ELF executable compiled for the target:
1/ There's no way the <pkg>_CONFIG_SCRIPTS mechanism can work
2/ There's no real point in keeping this file on the build machine,
because it's an executable built for the target.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-08-12 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 17:34 [Buildroot] [PATCH 1/1] postgresql: remove devfiles from target Floris Bos
2014-08-10 7:01 ` Thomas De Schampheleire
2014-08-10 10:55 ` Floris Bos
2014-08-10 12:54 ` Thomas De Schampheleire
2014-08-12 16:50 ` Thomas Petazzoni [this message]
2014-08-12 17:39 ` Floris Bos
2014-08-13 7:26 ` Thomas Petazzoni
2014-08-13 10:53 ` Floris Bos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812185019.57322578@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox