From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/infra: fix downloading versions with a slash
Date: Mon, 25 Aug 2014 23:10:51 +0200 [thread overview]
Message-ID: <20140825231051.53a3c18c@free-electrons.com> (raw)
In-Reply-To: <1408468875-6811-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Tue, 19 Aug 2014 19:21:15 +0200, Yann E. MORIN wrote:
> Since cset 54456cc (infra: consistently use double dollar signs...), it
> is no longer possible to download versions with a slash in it, because
> the _DL_VERSION variable is second-expanded, but the _VERSION variable
> is immediately-expanded to have '/' substitued with '_'.
>
> So, _DL_VERSION is only expanded at the time it is evaluated, and by
> that time, we've lost the slashes in _VERSION.
>
> Make the _DL_VERSION variables immediately-evaluated.
>
> Fixes:
> https://bugs.busybox.net/show_bug.cgi?id=7328
>
> Reported-by: Vincent Stehl? <vincent.stehle@freescale.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Vincent Stehl? <vincent.stehle@freescale.com>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-08-25 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 17:21 [Buildroot] [PATCH] package/infra: fix downloading versions with a slash Yann E. MORIN
2014-08-20 7:33 ` Vincent Stehlé
2014-08-21 14:45 ` Thomas De Schampheleire
2014-08-24 18:31 ` Thomas De Schampheleire
2014-08-25 21:10 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825231051.53a3c18c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox