From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] xscreensaver: link to gettext's libintl only when needed
Date: Fri, 29 Aug 2014 17:41:32 +0200 [thread overview]
Message-ID: <20140829174132.5e77dd3b@free-electrons.com> (raw)
In-Reply-To: <1409314139-25110-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Fri, 29 Aug 2014 13:08:59 +0100, Vicente Olivert Riera wrote:
> Use the BR2_NEEDS_GETTEXT option to link to gettext's libintl only when
> it's necessary.
>
> Fixes:
> http://autobuild.buildroot.net/results/ace/aceb83ff92957accab4e2f64e450b2d2837cb2ba/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/xscreensaver/xscreensaver.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/xscreensaver/xscreensaver.mk b/package/xscreensaver/xscreensaver.mk
> index 0e84d27..1d88c03 100644
> --- a/package/xscreensaver/xscreensaver.mk
> +++ b/package/xscreensaver/xscreensaver.mk
> @@ -14,7 +14,7 @@ XSCREENSAVER_LICENSE_FILES = hacks/screenhack.h hacks/glx/chessmodels.h
> XSCREENSAVER_DEPENDENCIES = jpeg libglade libgtk2 xlib_libX11 xlib_libXt \
> $(if $(BR2_PACKAGE_GETTEXT),gettext)
>
> -XSCREENSAVER_CONF_ENV = $(if $(BR2_PACKAGE_GETTEXT),LIBS=-lintl)
> +XSCREENSAVER_CONF_ENV = $(if $(BR2_NEED_GETTEXT_IF_LOCALE),LIBS=-lintl)
>
> # otherwise we end up with host include/library dirs passed to the
> # compiler/linker
There is already http://patchwork.ozlabs.org/patch/383576/, which seems
more complete than your patch, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-08-29 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 12:08 [Buildroot] [PATCH] xscreensaver: link to gettext's libintl only when needed Vicente Olivert Riera
2014-08-29 15:41 ` Thomas Petazzoni [this message]
2014-08-29 15:44 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829174132.5e77dd3b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox