From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libtirpc: add dependency on atomic operations
Date: Mon, 8 Sep 2014 09:23:06 +0200 [thread overview]
Message-ID: <20140908092306.12308c5a@free-electrons.com> (raw)
In-Reply-To: <1410157964-8422-2-git-send-email-abrodkin@synopsys.com>
Dear Alexey Brodkin,
On Mon, 8 Sep 2014 10:32:43 +0400, Alexey Brodkin wrote:
> Fixes:
> http://autobuild.buildroot.net/results/6bb90d3f2b840a1faacf152a1d93a909a2dc98d3
> http://autobuild.buildroot.net/results/994a84d192848b90a70e28e5ebaa769701bcaec9
>
> Following packages select "libtirpc", so adding dependency as well:
> * argus
> * conntrack-tools
> * lmbench
> * nfs-utils
> * quota
> * rpcbind
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
That's not that simple because you forget to update the comments: they
should not be displayed if the architecture doesn't have the atomic
intrinsics. And this is where things start to be really, really weird.
> diff --git a/package/conntrack-tools/Config.in b/package/conntrack-tools/Config.in
> index ec19d8e..36b12b7 100644
> --- a/package/conntrack-tools/Config.in
> +++ b/package/conntrack-tools/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS
> depends on BR2_INET_IPV6
> depends on BR2_LARGEFILE
> depends on BR2_USE_MMU # fork()
> + depends on BR2_ARCH_HAS_ATOMICS # libtirpc
That's not correct: if the toolchain has native RPC support, we do not
need libtirpc, so there is no need to depend on BR2_ARCH_HAS_ATOMICS in
this case.
I already tried to solve this thing, but it's much more complicated
than just adding a bunch of "depends on".
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-08 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 6:32 [Buildroot] [PATCH 0/2] add more dependencies on atomic operations Alexey Brodkin
2014-09-08 6:32 ` [Buildroot] [PATCH 1/2] libtirpc: add dependency " Alexey Brodkin
2014-09-08 7:23 ` Thomas Petazzoni [this message]
2014-09-08 9:23 ` Alexey Brodkin
2014-09-08 9:27 ` Thomas Petazzoni
2014-09-12 13:12 ` Alexey Brodkin
2014-09-12 13:25 ` Thomas Petazzoni
2014-09-12 13:31 ` Alexey Brodkin
2014-09-08 6:32 ` [Buildroot] [PATCH 2/2] zeromq: " Alexey Brodkin
2014-09-08 7:23 ` Thomas Petazzoni
2014-09-08 9:27 ` Alexey Brodkin
2014-09-08 9:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908092306.12308c5a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox