Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] coreutils: Do not install uptime
Date: Wed, 10 Sep 2014 22:45:29 +0200	[thread overview]
Message-ID: <20140910224529.24ee19a4@free-electrons.com> (raw)
In-Reply-To: <1410359406-49326-1-git-send-email-Vincent.Riera@imgtec.com>

Dear Vicente Olivert Riera,

On Wed, 10 Sep 2014 15:30:05 +0100, Vicente Olivert Riera wrote:
> coreutils' uptime doesn't work and its execution fails with a message
> like this one:
> 
>   uptime: couldn't get boot time: No such file or directory
> 
> busybox and procps-ng provide a working alternative.
> 
> This is a common old problem as we can see here:
> 
>   https://lists.openwrt.org/pipermail/openwrt-devel/2011-March/010006.html
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos.Chandras <Markos.Chandras@imgtec.com>
> ---
>  package/coreutils/coreutils.mk |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
> index 07a1347..7457b79 100644
> --- a/package/coreutils/coreutils.mk
> +++ b/package/coreutils/coreutils.mk
> @@ -61,7 +61,8 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \
>  		PERL=missing
>  
>  COREUTILS_CONF_OPT = --disable-rpath \
> -		--enable-install-program=hostname
> +		--enable-install-program=hostname \
> +		--enable-no-install-program=uptime

I think this is not the proper fix. A more appropriate fix is to
actually get uptime to work, which is a oneliner. See my patch posted
at http://patchwork.ozlabs.org/patch/387971/.

I'll mark your patch as Rejected in patchwork. Of course, if you
disagree, feel free to turn back your patch to the "New" state with an
explanation.

Thanks a lot for noticing this issue in the first place!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-09-10 20:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10 14:30 [Buildroot] [PATCH 1/2] coreutils: Do not install uptime Vicente Olivert Riera
2014-09-10 14:30 ` [Buildroot] [PATCH 2/2] procps-ng: Fix installation and take precedence over busybox Vicente Olivert Riera
2014-09-10 21:04   ` Thomas Petazzoni
2014-09-13 21:56   ` Peter Korsgaard
2014-09-10 20:45 ` Thomas Petazzoni [this message]
2014-09-11  9:13   ` [Buildroot] [PATCH 1/2] coreutils: Do not install uptime Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910224529.24ee19a4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox