From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 15 Sep 2014 16:29:14 +0200 Subject: [Buildroot] [PATCH] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of long unsigned int" In-Reply-To: <1410790003.5875.33.camel@abrodkin-8560l.internal.synopsys.com> References: <1410787585-20387-1-git-send-email-abrodkin@synopsys.com> <20140915155052.1b3283ae@free-electrons.com> <1410790003.5875.33.camel@abrodkin-8560l.internal.synopsys.com> Message-ID: <20140915162914.079b3507@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Alexey Brodkin, On Mon, 15 Sep 2014 14:06:43 +0000, Alexey Brodkin wrote: > > > diff --git a/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch b/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch > > > new file mode 100644 > > > index 0000000..78d4b10 > > > --- /dev/null > > > +++ b/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch > > > > Patch lacks a description + SoB. > > Well first of all IMHO patch name is self-explanatory. > Than I didn't want to duplicate the same text in commit message and in > patch itself. > > If you think this is helpful I will happily add the same text and URL in > the patch. > > Let me know what do you think about it. We have a stupid rule, and stupid rules are meant to be complied with :-) Joke aside, I think what you mentioned in the commit log is useful: what the patch does, and the fact that it's already "upstream" and therefore should be dropped at the next version bump of the ARC gcc compiler. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com