From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Outcome of the GSoC 2014
Date: Sat, 20 Sep 2014 12:24:06 +0200 [thread overview]
Message-ID: <20140920102406.GA3949@free.fr> (raw)
In-Reply-To: <20140919222504.GA19421@itchy>
Eric, All,
On 2014-09-20 00:25 +0200, Eric Le Bihan spake thusly:
> On Mon, Sep 15, 2014 at 11:16:01PM +0200, Thomas Petazzoni wrote:
> > Eric,
> >
> > On Mon, 15 Sep 2014 23:13:48 +0200, Eric Le Bihan wrote:
> >
> > > > We also have a few patches pending in patchwork from Hadrien, that
> > > > need adopters:
> > > >
> > > > * libgtk3: new package
> > > > http://patchwork.ozlabs.org/patch/375493/
> > > >
> > > > This one is almost ready, there are still a few fixes to be made. I
> > > > know Eric Le Bihan has also worked on libgtk3. Maybe Eric you could
> > > > take over this effort?
> > >
> > > I will adopt this patch.
> >
> > Awesome, thanks a lot!
>
> I have reworked the patch:
>
> - introduction of pkg-config-native in host-pkgconf.
> - addition of a dependency on host-pkgconf to host-libgtk3.
> - addition of multiple backend support (X11/Wayland/Broadway) in libgtk3.
>
> When one adopts a patch, how should the credits be edited? Do I keep the
> original author of the patch in the commit log and add myself in a
> "Signed-off-by" line with some comments, or vice-versa?
It depends. Here's how I do when I have that situation:
- if there is a substantial amount of the original code kept over, I
keep the original author as author. Then I had my SoB line.
- if the code from the original submitter is no longer used, because
everything was rewritten, then I make myself the author. Then I add
my SoB line, and change the original author's SoB into a Cc.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-09-20 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 19:44 [Buildroot] Outcome of the GSoC 2014 Thomas Petazzoni
2014-09-15 21:13 ` Eric Le Bihan
2014-09-15 21:16 ` Thomas Petazzoni
2014-09-19 22:25 ` Eric Le Bihan
2014-09-20 10:24 ` Yann E. MORIN [this message]
2014-09-20 11:11 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920102406.GA3949@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox