Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: libarchive: allow building as host package
Date: Sat, 27 Sep 2014 10:54:44 +0200	[thread overview]
Message-ID: <20140927085443.GA4298@free.fr> (raw)
In-Reply-To: <1411773795-7803-1-git-send-email-guido@vanguardiasur.com.ar>

Guido, All,

What is the rationale for building it as a host-package?

libarchive provides a library, but we have no in-tree host-package that
uses libarchive.

On 2014-09-26 20:23 -0300, Guido Mart?nez spake thusly:
> It works correctly without any changes, so just enable it.

This should not be part of the commit log. The commit log should just
explain why you enable host-libarchive, especially because we have no
in-tree user.

Regards,
Yann E. MORIN.

> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
>  package/libarchive/libarchive.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> index 8c6951d..22914c2 100644
> --- a/package/libarchive/libarchive.mk
> +++ b/package/libarchive/libarchive.mk
> @@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib
>  endif
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-09-27  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 23:23 [Buildroot] [PATCH] package: libarchive: allow building as host package Guido Martínez
2014-09-27  8:54 ` Yann E. MORIN [this message]
2014-09-27 12:28   ` Guido Martínez
2014-09-27 12:37     ` Yann E. MORIN
2014-09-28  9:04   ` Samuel Martin
2014-10-11 17:27 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140927085443.GA4298@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox