From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2] check-deprecated-variable: move from pkg-generic.mk to pkg-utils.mk
Date: Sun, 5 Oct 2014 10:13:30 +0200 [thread overview]
Message-ID: <20141005081330.GB4220@free.fr> (raw)
In-Reply-To: <98b4f7f5e2ea63e41fa1.1412495911@localhost>
Thomas, All,
On 2014-10-05 09:58 +0200, Thomas De Schampheleire spake thusly:
> Suggested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-generic.mk | 15 ---------------
> package/pkg-utils.mk | 9 +++++++++
> 2 files changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -264,21 +264,6 @@
> endef
>
> ################################################################################
> -# check-deprecated-variable -- throw an error on deprecated variables
> -#
> -# argument 1 is the deprecated variable
> -# argument 2 is the new variable to use
> -#
> -# example:
> -# $(eval $(call check-deprecated-variable,FOO_MAKE_OPT,FOO_MAKE_OPTS))
> -################################################################################
> -define check-deprecated-variable
> -ifneq ($$(origin $(1)),undefined)
> -$$(error Package error: use $(2) instead of $(1). Please fix your .mk file)
> -endif
> -endef
> -
> -################################################################################
> # inner-generic-package -- generates the make targets needed to build a
> # generic package
> #
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -88,6 +88,15 @@
>
> endef
>
> +# check-deprecated-variable -- throw an error on deprecated variables
> +# example:
> +# $(eval $(call check-deprecated-variable,FOO_MAKE_OPT,FOO_MAKE_OPTS))
> +define check-deprecated-variable # (deprecated var, new var)
> +ifneq ($$(origin $(1)),undefined)
> +$$(error Package error: use $(2) instead of $(1). Please fix your .mk file)
> +endif
> +endef
> +
> #
> # legal-info helper functions
> #
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-05 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 7:58 [Buildroot] [PATCH 1 of 2] check-deprecated-variable: move from pkg-generic.mk to pkg-utils.mk Thomas De Schampheleire
2014-10-05 7:58 ` [Buildroot] [PATCH 2 of 2] check-deprecated-variable: move call to respective infra where appropriate Thomas De Schampheleire
2014-10-05 8:15 ` Yann E. MORIN
2014-10-05 11:39 ` Thomas Petazzoni
2014-10-05 8:13 ` Yann E. MORIN [this message]
2014-10-05 11:39 ` [Buildroot] [PATCH 1 of 2] check-deprecated-variable: move from pkg-generic.mk to pkg-utils.mk Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141005081330.GB4220@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox